Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Move the third party repositories to a c-deps/repositories.bzl rule #56053

Closed
jlinder opened this issue Oct 28, 2020 · 1 comment · Fixed by #56525
Closed

build: Move the third party repositories to a c-deps/repositories.bzl rule #56053

jlinder opened this issue Oct 28, 2020 · 1 comment · Fixed by #56525
Labels
A-build-system C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@jlinder
Copy link
Collaborator

jlinder commented Oct 28, 2020

This is similar to how vendor is in there.
@jlinder jlinder added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-build-system labels Oct 28, 2020
@otan otan mentioned this issue Nov 9, 2020
Closed
@alan-mas
Copy link
Contributor

Working on it.

@alan-mas alan-mas mentioned this issue Nov 10, 2020
Merged
alan-mas added a commit to alan-mas/cockroach that referenced this issue Nov 10, 2020
@alan-mas
bazel: Move third party repositories to c-deps/REPOSITORIES.bzl
fc5f15c 
This is one of the Bazel re-factoring that we are working on
and it is about to move third party repositories out of root WORKSPACE cockroachdb#56053

Best practices is to separate external dependencies and it also
hides the repo WORKSPACE from beign used by other directories.

We are creating a new .bzl file inside c-deps with all the external dependencies
and then load then inside our root WORKSPACE

Release note: None
alan-mas added a commit to alan-mas/cockroach that referenced this issue Nov 12, 2020
@alan-mas
bazel: Move third party repositories to c-deps/REPOSITORIES.bzl
4936cfe 
This is one of the Bazel re-factoring that we are working on
and it is about to move third party repositories out of root WORKSPACE cockroachdb#56053

Best practices is to separate external dependencies and it also
hides the repo WORKSPACE from beign used by other directories.

We are creating a new .bzl file inside c-deps with all the external dependencies
and then load then inside our root WORKSPACE

Release note: None
@craig craig bot closed this as completed in a5e67b6 Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build-system C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bazel: Move third party repositories to c-deps/REPOSITORIES.bzl alan-mas/cockroach
2 participants
@jlinder @alan-mas