Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: make CONNECTION LIMIT = -1 a no-op #54116

Closed
awoods187 opened this issue Sep 9, 2020 · 0 comments · Fixed by #54219
Closed

sql: make CONNECTION LIMIT = -1 a no-op #54116

awoods187 opened this issue Sep 9, 2020 · 0 comments · Fixed by #54219
Assignees
@otan
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@awoods187
Copy link
Contributor

At table creation, Postgres supports a notion of infinite connection limits via CONNECTION LIMIT = -1. We should make this a no-op as it isn't relevant with CockroachDB.
@awoods187 awoods187 added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Sep 9, 2020
@otan otan self-assigned this Sep 10, 2020
@otan otan mentioned this issue Sep 10, 2020
Merged
@awoods187 awoods187 mentioned this issue Sep 15, 2020
Closed
@otan otan mentioned this issue Sep 15, 2020
Merged
@craig craig bot closed this as completed in 2ae4b3a Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otan otan

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: allow CONNECTION LIMIT syntax for CREATE DATABASE otan-cockroach/cockroach
2 participants
@otan @awoods187