Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: quit-all-nodes failed #53630

Closed
cockroach-teamcity opened this issue Aug 29, 2020 · 8 comments
Closed

roachtest: quit-all-nodes failed #53630

cockroach-teamcity opened this issue Aug 29, 2020 · 8 comments
Assignees
@irfansharif
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone
20.2

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).quit-all-nodes failed on master@8b91062f9351d18f9104aff567cb152df162021e:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/quit-all-nodes/run_1
	quit.go:402,quit.go:431,quit.go:142,context.go:135,quit.go:141,quit.go:431,test_runner.go:754: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2231078-1598711360-20-n5cpu4:5 -- ./cockroach quit --insecure --logtostderr=INFO --port={pgport:5} --drain-wait=1h: exit status 20
		(1) attached stack trace
		  -- stack trace:
		  | main.execCmdWithBuffer
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:552
		  | main.(*cluster).RunWithBuffer
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2282
		  | main.runQuit
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:399
		  | main.registerQuitAllNodes.func1.1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:431
		  | main.(*quitTest).runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:142
		  | github.com/cockroachdb/cockroach/pkg/util/contextutil.RunWithTimeout
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/util/contextutil/context.go:135
		  | main.(*quitTest).runWithTimeout
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:141
		  | main.registerQuitAllNodes.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:431
		  | main.(*testRunner).runTest.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test_runner.go:754
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1357
		Wraps: (2) /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2231078-1598711360-20-n5cpu4:5 -- ./cockroach quit --insecure --logtostderr=INFO --port={pgport:5} --drain-wait=1h
		Wraps: (3) exit status 20
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *exec.ExitError
More

Artifacts: /quit-all-nodes

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Aug 29, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Aug 29, 2020
@cockroach-teamcity
Copy link
Member Author

(roachtest).quit-all-nodes failed on master@8746e7e347dbbc19be051168225cd4fab0582294:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/quit-all-nodes/run_1
	quit.go:402,quit.go:431,quit.go:142,context.go:135,quit.go:141,quit.go:431,test_runner.go:754: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2232292-1598767987-20-n5cpu4:5 -- ./cockroach quit --insecure --logtostderr=INFO --port={pgport:5} --drain-wait=1h: exit status 20
		(1) attached stack trace
		  -- stack trace:
		  | main.execCmdWithBuffer
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:552
		  | main.(*cluster).RunWithBuffer
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2282
		  | main.runQuit
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:399
		  | main.registerQuitAllNodes.func1.1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:431
		  | main.(*quitTest).runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:142
		  | github.com/cockroachdb/cockroach/pkg/util/contextutil.RunWithTimeout
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/util/contextutil/context.go:135
		  | main.(*quitTest).runWithTimeout
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:141
		  | main.registerQuitAllNodes.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:431
		  | main.(*testRunner).runTest.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test_runner.go:754
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1357
		Wraps: (2) /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2232292-1598767987-20-n5cpu4:5 -- ./cockroach quit --insecure --logtostderr=INFO --port={pgport:5} --drain-wait=1h
		Wraps: (3) exit status 20
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *exec.ExitError
More

Artifacts: /quit-all-nodes

See this test on roachdash
powered by pkg/cmd/internal/issues

@irfansharif irfansharif self-assigned this Aug 30, 2020
@cockroach-teamcity
Copy link
Member Author

(roachtest).quit-all-nodes failed on master@cd8267ca84f6a0267a898220cfaa6630188b45c5:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/quit-all-nodes/run_1
	quit.go:402,quit.go:431,quit.go:142,context.go:135,quit.go:141,quit.go:431,test_runner.go:754: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2233513-1598854390-20-n5cpu4:5 -- ./cockroach quit --insecure --logtostderr=INFO --port={pgport:5} --drain-wait=1h: exit status 20
		(1) attached stack trace
		  -- stack trace:
		  | main.execCmdWithBuffer
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:552
		  | main.(*cluster).RunWithBuffer
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2282
		  | main.runQuit
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:399
		  | main.registerQuitAllNodes.func1.1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:431
		  | main.(*quitTest).runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:142
		  | github.com/cockroachdb/cockroach/pkg/util/contextutil.RunWithTimeout
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/util/contextutil/context.go:135
		  | main.(*quitTest).runWithTimeout
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:141
		  | main.registerQuitAllNodes.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:431
		  | main.(*testRunner).runTest.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test_runner.go:754
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1357
		Wraps: (2) /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2233513-1598854390-20-n5cpu4:5 -- ./cockroach quit --insecure --logtostderr=INFO --port={pgport:5} --drain-wait=1h
		Wraps: (3) exit status 20
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *exec.ExitError
More

Artifacts: /quit-all-nodes

See this test on roachdash
powered by pkg/cmd/internal/issues

@knz
Copy link
Contributor

knz commented Aug 31, 2020

Symptom


ERROR: hard shutdown failed: node cannot be shut down before it has been initialized

@cockroach-teamcity
Copy link
Member Author

(roachtest).quit-all-nodes failed on master@57e160b1fcc41dd12b595953729728007fd3fbda:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/quit-all-nodes/run_1
	quit.go:402,quit.go:431,quit.go:142,context.go:135,quit.go:141,quit.go:431,test_runner.go:754: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2240589-1599026582-70-n5cpu4:5 -- ./cockroach quit --insecure --logtostderr=INFO --port={pgport:5} --drain-wait=1h: exit status 20
		(1) attached stack trace
		  -- stack trace:
		  | main.execCmdWithBuffer
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:552
		  | main.(*cluster).RunWithBuffer
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2296
		  | main.runQuit
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:399
		  | main.registerQuitAllNodes.func1.1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:431
		  | main.(*quitTest).runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:142
		  | github.com/cockroachdb/cockroach/pkg/util/contextutil.RunWithTimeout
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/util/contextutil/context.go:135
		  | main.(*quitTest).runWithTimeout
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:141
		  | main.registerQuitAllNodes.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:431
		  | main.(*testRunner).runTest.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test_runner.go:754
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1357
		Wraps: (2) /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2240589-1599026582-70-n5cpu4:5 -- ./cockroach quit --insecure --logtostderr=INFO --port={pgport:5} --drain-wait=1h
		Wraps: (3) exit status 20
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *exec.ExitError
More

Artifacts: /quit-all-nodes

See this test on roachdash
powered by pkg/cmd/internal/issues

@irfansharif
Copy link
Contributor

I expect this to be mitigated by #53713. The failures here co-incide with #52526 landing. Though I think fundamentally roachtests are missing this readiness check infrastructure that we should add if issues like this keep popping up.

@cockroach-teamcity
Copy link
Member Author

(roachtest).quit-all-nodes failed on master@11a82264044ed8edc7d1fca2b912296d6f576a1a:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/quit-all-nodes/run_1
	quit.go:402,quit.go:431,quit.go:142,context.go:135,quit.go:141,quit.go:431,test_runner.go:754: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2243794-1599113210-20-n5cpu4:5 -- ./cockroach quit --insecure --logtostderr=INFO --port={pgport:5} --drain-wait=1h: exit status 20
		(1) attached stack trace
		  -- stack trace:
		  | main.execCmdWithBuffer
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:552
		  | main.(*cluster).RunWithBuffer
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2296
		  | main.runQuit
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:399
		  | main.registerQuitAllNodes.func1.1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:431
		  | main.(*quitTest).runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:142
		  | github.com/cockroachdb/cockroach/pkg/util/contextutil.RunWithTimeout
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/util/contextutil/context.go:135
		  | main.(*quitTest).runWithTimeout
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:141
		  | main.registerQuitAllNodes.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:431
		  | main.(*testRunner).runTest.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test_runner.go:754
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1357
		Wraps: (2) /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2243794-1599113210-20-n5cpu4:5 -- ./cockroach quit --insecure --logtostderr=INFO --port={pgport:5} --drain-wait=1h
		Wraps: (3) exit status 20
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *exec.ExitError
More

Artifacts: /quit-all-nodes

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).quit-all-nodes failed on master@9fae2abb48a00c26ac0344f35cd100df7faa2aec:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/quit-all-nodes/run_1
	quit.go:402,quit.go:431,quit.go:142,context.go:135,quit.go:141,quit.go:431,test_runner.go:754: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2247288-1599199488-68-n5cpu4:5 -- ./cockroach quit --insecure --logtostderr=INFO --port={pgport:5} --drain-wait=1h: exit status 20
		(1) attached stack trace
		  -- stack trace:
		  | main.execCmdWithBuffer
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:561
		  | main.(*cluster).RunWithBuffer
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2305
		  | main.runQuit
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:399
		  | main.registerQuitAllNodes.func1.1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:431
		  | main.(*quitTest).runWithTimeout.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:142
		  | github.com/cockroachdb/cockroach/pkg/util/contextutil.RunWithTimeout
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/util/contextutil/context.go:135
		  | main.(*quitTest).runWithTimeout
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:141
		  | main.registerQuitAllNodes.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/quit.go:431
		  | main.(*testRunner).runTest.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test_runner.go:754
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1357
		Wraps: (2) /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod run teamcity-2247288-1599199488-68-n5cpu4:5 -- ./cockroach quit --insecure --logtostderr=INFO --port={pgport:5} --drain-wait=1h
		Wraps: (3) exit status 20
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *exec.ExitError
More

Artifacts: /quit-all-nodes

See this test on roachdash
powered by pkg/cmd/internal/issues

@irfansharif
Copy link
Contributor

I expect this to be fixed by #53713. I'll let it re-file if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irfansharif irfansharif

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Milestone
20.2
Development

No branches or pull requests
3 participants
@knz @irfansharif @cockroach-teamcity