Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: NPE during RESTORE rollback #52383

Closed
pbardea opened this issue Aug 5, 2020 · 0 comments · Fixed by #53928
Closed

backupccl: NPE during RESTORE rollback #52383

pbardea opened this issue Aug 5, 2020 · 0 comments · Fixed by #53928
Assignees
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.

Comments

@pbardea
Copy link
Contributor

pbardea commented Aug 5, 2020

While cancelling a RESTORE job, the coordinator crashes with the following NPE:

I200805 02:47:06.560063 1551 jobs/registry.go:1240  job 578435388608741377: resuming execution
I200805 02:47:06.564606 183009 jobs/registry.go:842  [n1] job 578435388608741377: stepping through state reverting with error: job canceled by user
E200805 02:47:06.568147 183009 util/log/crash_reporting.go:138  [n1] a panic has occurred!
runtime error: invalid memory address or nil pointer dereference
(1) attached stack trace
  | runtime.gopanic
  |     /usr/local/go/src/runtime/panic.go:969
  | runtime.panicmem
  |     /usr/local/go/src/runtime/panic.go:212
  | runtime.sigpanic
  |     /usr/local/go/src/runtime/signal_unix.go:695
  | github.com/cockroachdb/cockroach/pkg/ccl/backupccl.(*restoreResumer).dropTables
  |     /go/src/github.com/cockroachdb/cockroach/pkg/ccl/backupccl/restore_job.go:1188
  | github.com/cockroachdb/cockroach/pkg/ccl/backupccl.(*restoreResumer).OnFailOrCancel.func1
  |     /go/src/github.com/cockroachdb/cockroach/pkg/ccl/backupccl/restore_job.go:1172
  | github.com/cockroachdb/cockroach/pkg/kv.(*DB).Txn.func1
  |     /go/src/github.com/cockroachdb/cockroach/pkg/kv/db.go:707
  | github.com/cockroachdb/cockroach/pkg/kv.(*Txn).exec
  |     /go/src/github.com/cockroachdb/cockroach/pkg/kv/txn.go:811
  | github.com/cockroachdb/cockroach/pkg/kv.(*DB).Txn
  |     /go/src/github.com/cockroachdb/cockroach/pkg/kv/db.go:706
  | github.com/cockroachdb/cockroach/pkg/ccl/backupccl.(*restoreResumer).OnFailOrCancel
  |     /go/src/github.com/cockroachdb/cockroach/pkg/ccl/backupccl/restore_job.go:1164
  | github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine
  |     /go/src/github.com/cockroachdb/cockroach/pkg/jobs/registry.go:911
  | github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resume.func1
  |     /go/src/github.com/cockroachdb/cockroach/pkg/jobs/registry.go:986
  | github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTask.func1
  |     /go/src/github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:347
  | runtime.goexit
  |     /usr/local/go/src/runtime/asm_amd64.s:1373
Wraps: (2) runtime error: invalid memory address or nil pointer dereference
Error types: (1) *withstack.withStack (2) runtime.errorString

On this line: https://github.com/cockroachdb/cockroach/blob/master/pkg/ccl/backupccl/restore_job.go#L1188

@pbardea pbardea added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-disaster-recovery labels Aug 5, 2020
@pbardea pbardea self-assigned this Aug 5, 2020
@pbardea pbardea added the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Sep 8, 2020
@craig craig bot closed this as completed in bdcb2f7 Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant