Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add FormatVersion field to PrivilegeDescriptor #51930

Closed
Tracked by #52021
RichardJCai opened this issue Jul 27, 2020 · 0 comments · Fixed by #52701
Closed
Tracked by #52021

sql: add FormatVersion field to PrivilegeDescriptor #51930

RichardJCai opened this issue Jul 27, 2020 · 0 comments · Fixed by #52701
Assignees
@RichardJCai
Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@RichardJCai
Copy link
Contributor

After adding ownership to PrivilegeDescriptors, to be able to validate ownership, we have to know the version of the PrivilegedDescriptor.

Versions before the addition of the ownership field are allowed to have an empty owner field whereas versions after should have owners.
@RichardJCai RichardJCai added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-schema-descriptors Relating to SQL table/db descriptor handling. labels Jul 27, 2020
@RichardJCai RichardJCai self-assigned this Jul 27, 2020
@RichardJCai RichardJCai mentioned this issue Jul 28, 2020
Closed
10 tasks
@RichardJCai RichardJCai mentioned this issue Aug 12, 2020
Merged
@craig craig bot closed this as completed in fad5ca5 Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RichardJCai RichardJCai

Labels
A-schema-descriptors Relating to SQL table/db descriptor handling. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add version field to PrivilegeDescriptor RichardJCai/cockroach
1 participant
@RichardJCai