Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add DROP DATABASE CASCADE test mode to logic tests #51254

Closed
jordanlewis opened this issue Jul 9, 2020 · 1 comment
Closed

sql: add DROP DATABASE CASCADE test mode to logic tests #51254

jordanlewis opened this issue Jul 9, 2020 · 1 comment
Assignees
@ajwerner
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@jordanlewis
Copy link
Member

We've seen a few issues caused by DROP DATABASE CASCADE creating invalid descriptors, especially after the GC TTL ends.

We should add a test mode to the logic test suite that runs DROP DATABASE CASCADE at the end of tests, waits the GC TTL, and then runs validate on all table descriptors (or triggers the validate loop proposed in #51153. Hopefully, that would catch issues like #50712, #50997, #49940 and so on.
@jordanlewis jordanlewis added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Jul 9, 2020
@ajwerner
Copy link
Contributor

Closed by #53810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajwerner ajwerner

Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordanlewis @ajwerner