Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: error in gopsutil breaks build on FreeBSD #51142

Closed
knz opened this issue Jul 8, 2020 · 2 comments · Fixed by #51418
Closed

deps: error in gopsutil breaks build on FreeBSD #51142

knz opened this issue Jul 8, 2020 · 2 comments · Fixed by #51418
Labels
A-kv-server Relating to the KV-level RPC server B-os-bsd Issues specific to a BSD OS (non-macOS) C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-productivity Severe issues that impede the productivity of CockroachDB developers.

Comments

@knz
Copy link
Contributor

knz commented Jul 8, 2020 

# github.com/shirou/gopsutil/disk
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:195:43: cannot use stat.Fstypename[:] (type []byte) as type []int8 in argument to common.IntToString

this is new since the dep was bumped
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-productivity Severe issues that impede the productivity of CockroachDB developers. B-os-bsd Issues specific to a BSD OS (non-macOS) A-kv-server Relating to the KV-level RPC server labels Jul 8, 2020
@knz
Copy link
Contributor Author

knz commented Jul 8, 2020

Fixed with this patch:

@@ -192,5 +193,5 @@ func parseDevstat(buf []byte) (Devstat, error) {
 }

 func getFsType(stat unix.Statfs_t) string {
-       return common.IntToString(stat.Fstypename[:])
+       return string(stat.Fstypename[:])
 }

@knz
Copy link
Contributor Author

knz commented Jul 14, 2020

Filed upstream: shirou/gopsutil#906

@knz knz mentioned this issue Jul 14, 2020
Merged
@craig craig bot closed this as completed in b54e948 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-kv-server Relating to the KV-level RPC server B-os-bsd Issues specific to a BSD OS (non-macOS) C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-productivity Severe issues that impede the productivity of CockroachDB developers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: bump github.com/shirou/gopsutil knz/cockroach
1 participant
@knz