sql,metrics: ROLLBACK after RELEASE cockroach_restart misclassified in metrics #50780
Labels
A-sql-execution
Relating to SQL execution.
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
BEGIN; SAVEPOINT cockroach_restart; ...; RELEASE SAVEPOINT cockroach_restart; ROLLBACK;
currently increments the following four metrics:This last metric is incorrect. We should be incrementing the
sql.txn.commit.count
metric instead, because the transaction has committed.The fix for this will be to update
StatementCounters.incrementCount
with condition logic in thetree.RollbackTransaction
case that consults the session's state.The text was updated successfully, but these errors were encountered: