Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/multitenancy: eventlog should use sql instance IDs to be compatible with multitenancy #50047

Closed
Tracked by #52617
asubiotto opened this issue Jun 10, 2020 · 3 comments
Assignees
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced.

Comments

@asubiotto
Copy link
Contributor

asubiotto commented Jun 10, 2020

Seen in testdata/logic_test/event_log:

        testdata/logic_test/event_log:22: SELECT "reportingID", info::JSONB->>'TableName'
          FROM system.eventlog
         WHERE "eventType" = 'create_table'
        expected:
            1  test.public.a
            1  test.public.b

        but found (query options: "rowsort" -> ignore the following ordering of rows) :
            10001  test.public.a
            10001  test.public.b

The node ID is stored and printed out (the 10001 is a bogus node ID). These should be sql instance IDs instead (#48009)

Jira issue: CRDB-4158

@asubiotto asubiotto added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multitenancy Related to multi-tenancy labels Jun 10, 2020
@asubiotto
Copy link
Contributor Author

cc @jordanlewis this is not urgent but it makes me wonder who owns event log? Is that sql execution?

@asubiotto asubiotto changed the title sql: eventlog should use sql instance IDs to be compatible with multitenancy sql/multitenancy: eventlog should use sql instance IDs to be compatible with multitenancy Jun 10, 2020
@vy-ton
Copy link
Contributor

vy-ton commented Feb 4, 2021

cc @thtruo for awareness of log issue with Serverless

@RaduBerinde RaduBerinde added the E-quick-win Likely to be a quick win for someone experienced. label Nov 11, 2021
@knz knz self-assigned this Jun 14, 2022
@knz
Copy link
Contributor

knz commented Jun 14, 2022

This has been addressed in #64894.

@knz knz closed this as completed Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced.
Projects
None yet
Development

No branches or pull requests

4 participants