Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

physicalplan: avoid serialization of expressions on the gateway in distributed flows #49810

Closed
yuzefovich opened this issue Jun 2, 2020 · 0 comments · Fixed by #49891
Closed

physicalplan: avoid serialization of expressions on the gateway in distributed flows #49810

yuzefovich opened this issue Jun 2, 2020 · 0 comments · Fixed by #49891
Assignees
@yuzefovich
Labels
A-sql-execution Relating to SQL execution. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@yuzefovich
Copy link
Member

Currently we do expression serialization on all nodes, including the gateway, if the flow is distributed: in MakeExpression we call ctx.IsLocal() to decide whether we should serialize the expression, and that call returns true only when PlanningCtx.isLocal is true which is the case only when the flow is not distributed. I think we could be smarter and avoid the serialization on the gateway node, but it doesn't seem trivial.
@yuzefovich yuzefovich added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-execution Relating to SQL execution. labels Jun 2, 2020
@yuzefovich yuzefovich mentioned this issue Jun 5, 2020
Merged
@craig craig bot closed this as completed in 2ae3d3c Jun 10, 2020
@rafiss rafiss mentioned this issue Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
A-sql-execution Relating to SQL execution. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

physicalplan: preevaluate subqueries on LocalExprs and always set LocalExprs yuzefovich/cockroach
1 participant
@yuzefovich