Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: std deviation not visible on statements list page #49706

Closed
piyush-singh opened this issue May 29, 2020 · 4 comments
Closed

ui: std deviation not visible on statements list page #49706

piyush-singh opened this issue May 29, 2020 · 4 comments
Labels
A-sql-ui Why is my query slow? A-webui-queryperf C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. no-issue-activity X-stale

Comments

@piyush-singh
Copy link

piyush-singh commented May 29, 2020

While @nstewart was exploring slow statements in a cluster, he noted that overall p99 latencies were high, but it was difficult to spot the offending queries on the statements list page. After digging into the statement details, he was able to find a query with very high variance:

image

However this isn't visible on the statement list unless the you hover over the statement in question:
image

We should explore how we can make this easier to spot without requiring hovering over each statement. This may be a bug/regression on this page from the design update.

cc @Annebirzin and @awoods187

Jira issue: CRDB-4206

@piyush-singh piyush-singh added A-webui-queryperf C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels May 29, 2020
@cockroachdb cockroachdb deleted a comment from blathers-crl bot May 29, 2020
@awoods187 awoods187 added the A-sql-ui Why is my query slow? label May 29, 2020
@dhartunian
Copy link
Collaborator

The scaling here is based on other items in the list so there's likely a separate item that has a really high mean.

Would be cool to explore adding a ratio of stdev/mean (https://en.wikipedia.org/wiki/Coefficient_of_variation) which would allow comparison but I wonder if this would cause more confusion since it's not a measure that folks are as familiar with.

Another option could be to have a ratio past which we should a yellow ⚠️ or something by the statement to highlight to the customer.

@nstewart
Copy link
Contributor

nstewart commented May 29, 2020

Any reason we can't explicitly show the std dev as a column? Def don't want to suggest a specific design, but if we can't find one that is clear - that approach might be helpful. It looks like we talk about pairs of means and std dev throughout the UI.

Or if we want to roughly combine a mean and stdv into one number, why not start with a p99 in the column? I'm sure we put some thought into this already, but one thing I'm confused by is our starting with "Service Latency: SQL, 99th percentile" in the main metrics page, then our transition to talking about mean latency in the statements page. Why do we make that switch in the type of latency we show?

@nstewart
Copy link
Contributor

@ajwerner 's point of view on arbitrary latencies: #49658 (comment)

@github-actions
Copy link

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
10 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-ui Why is my query slow? A-webui-queryperf C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. no-issue-activity X-stale
Projects
None yet
Development

No branches or pull requests

4 participants