Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colexec: re-enable short-circuiting of hash join #49631

Closed
cockroach-teamcity opened this issue May 28, 2020 · 6 comments · Fixed by #52016
Closed

colexec: re-enable short-circuiting of hash join #49631

cockroach-teamcity opened this issue May 28, 2020 · 6 comments · Fixed by #52016
Assignees
@asubiotto
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
20.2

Comments

@cockroach-teamcity
Copy link
Member

(sql/logictest).TestSqlLiteLogic/local/slt_good_1.test#09 failed on master@d8a0f6c2ad31df7f5dc34b5e1bd74bc2f056c2cd:

Slow failing tests:
TestSqlLiteLogic/local/slt_good_1.test#09 - 86399.99s

Slow passing tests:
<none>
More

make stressrace TESTS=TestSqlLiteLogic/local/slt_good_1.test#09 PKG=./pkg/sql/logictest TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels May 28, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone May 28, 2020
@yuzefovich
Copy link
Member

Hm, I wonder whether this timeout is somehow due to the limit being too low.

The most suspicious goroutine in the stack trace is

18768 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088559841-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"goroutine 96544734 [chan receive]:\n"}^M
18769 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088570952-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*Di      stSender).divideAndSendBatchToRanges.func1(0xc000d197e8, 0xc000d19a48, 0xc000d19a40, 0xc000d19669, 0xc000d19980, 0xc000d197d0, 0xc000d1966c)\n"}^M
18770 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.08858085-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvc      oord/dist_sender.go:1178 +0xdf\n"}^M
18771 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088588757-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*Di      stSender).divideAndSendBatchToRanges(0xc10f7d17a0, 0x47e5800, 0xc26ee60e70, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\n"}^M
18772 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088602061-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvclient/kv      coord/dist_sender.go:1331 +0x7bd\n"}^M
18773 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088609695-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*Di      stSender).Send(0xc10f7d17a0, 0x47e5800, 0xc26ee60e70, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\n"}^M
18774 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088617795-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvclient/kv      coord/dist_sender.go:768 +0x797\n"}^M
18775 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088625713-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*tx      nLockGatekeeper).SendLocked(0xc01d377ac8, 0x47e5800, 0xc26ee60e70, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\n"}^M
18776 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088642192-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvclient/kv      coord/txn_lock_gatekeeper.go:86 +0x10b\n"}^M
18777 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088650345-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*tx      nMetricRecorder).SendLocked(0xc01d377a90, 0x47e5800, 0xc26ee60e70, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\n"}^M
18778 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.08865793-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvc      oord/txn_interceptor_metric_recorder.go:46 +0x8d\n"}^M
18779 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088666027-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*tx      nCommitter).SendLocked(0xc01d377a60, 0x47e5800, 0xc26ee60e70, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\n"}^M
18780 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088676654-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvclient/kv      coord/txn_interceptor_committer.go:195 +0x118\n"}^M
18781 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088685018-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*tx      nSpanRefresher).sendLockedWithRefreshAttempts(0xc01d3779c8, 0x47e5800, 0xc26ee60e70, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\n"}^M
18782 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088693118-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvclient/kv      coord/txn_interceptor_span_refresher.go:247 +0x9b\n"}^M
18783 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088704627-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*tx      nSpanRefresher).SendLocked(0xc01d3779c8, 0x47e5800, 0xc26ee60e70, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\n"}^M
18784 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088717042-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvclient/kv      coord/txn_interceptor_span_refresher.go:182 +0x180\n"}^M
18785 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088727973-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*tx      nPipeliner).SendLocked(0xc01d377908, 0x47e5800, 0xc26ee60e70, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\n"}^M
18786 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088736209-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvclient/kv      coord/txn_interceptor_pipeliner.go:252 +0x159\n"}^M
18787 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088744107-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*tx      nSeqNumAllocator).SendLocked(0xc01d3778e8, 0x47e5800, 0xc26ee60e70, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\n"}^M
18788 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088754464-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvclient/kv      coord/txn_interceptor_seq_num_allocator.go:105 +0x20c\n"}^M
18789 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088763298-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*tx      nHeartbeater).SendLocked(0xc01d377848, 0x47e5800, 0xc26ee60e70, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\n"}^M
18790 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088771994-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvclient/kv      coord/txn_interceptor_heartbeater.go:172 +0x1a9\n"}^M
18791 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088786189-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord.(*Tx      nCoordSender).Send(0xc01d377680, 0x47e5800, 0xc26ee60e70, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\n"}^M
18792 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088794455-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/kvclient/kv      coord/txn_coord_sender.go:503 +0x406\n"}^M
18793 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088801852-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv.(*DB).sendUsingSender      (0xc1b0517080, 0x47e5740, 0xc01da3e300, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\n"}^M
18794 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088810095-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/db.go:749 +      0x122\n"}^M
18795 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.08881999-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv.(*Txn).Send(0xc0388c56      80, 0x47e5740, 0xc01da3e300, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)\n"}^M
18796 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.08882863-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/txn.go:908 +      0x11e\n"}^M
18797 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088840091-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv.sendAndFill(0x47e5740      , 0xc01da3e300, 0xc000d1b178, 0xc00cbc2580, 0x0, 0x0)\n"}^M
18798 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088848156-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/db.go:659 +      0xf7\n"}^M
18799 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088855635-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv.(*Txn).Run(0xc0388c56      80, 0x47e5740, 0xc01da3e300, 0xc00cbc2580, 0x0, 0x0)\n"}^M
18800 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088863719-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/txn.go:579       +0xfa\n"}^M
18801 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088874881-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/kv.(*Txn).CommitInBatch(      0xc0388c5680, 0x47e5740, 0xc01da3e300, 0xc00cbc2580, 0x12, 0x0)\n"}^M
18802 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088883507-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/kv/txn.go:641       +0x15c\n"}^M
18803 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088890371-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*tableWriterBase).f      inalize(0xc0533ed3a8, 0x47e5740, 0xc01da3e300, 0xc01da19b00, 0xc00dd35cd0, 0xc1c1ada200)\n"}^M
18804 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088898507-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/tablewrite      r.go:149 +0xa5\n"}^M
18805 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088906141-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*tableDeleter).fina      lize(...)\n"}^M
18806 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.08891725-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/tablewriter      _delete.go:57\n"}^M
18807 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088925296-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*deleteNode).Batche      dNext(0xc0533ed380, 0x47e5740, 0xc01da3e300, 0xc00011e580, 0xc00dd35cd0, 0x3be1500, 0xc000d1b301, 0x0)\n"}^M
18808 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088932741-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/delete.go:      152 +0x221\n"}^M
18809 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088940291-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*rowCountNode).star      tExec(0xc00c47a1e0, 0x47e5740, 0xc01da3e300, 0xc00011e580, 0xc00dd35cd0, 0xc000d1b300, 0x30c23a5)\n"}^M
18810 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.08894821-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/plan_batch.      go:159 +0xcd\n"}^M
18811 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088960492-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.startExec.func2(0x3f      9577a, 0x5, 0x47e7bc0, 0xc00c47a1e0, 0x0, 0x0)\n"}^M
18812 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088968001-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/plan.go:43      2 +0xb9\n"}^M
18813 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088978278-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*planVisitor).visit      Internal.func1(0xc000d1bb78, 0x3f9577a, 0x5, 0x47e7bc0, 0xc00c47a1e0)\n"}^M
18814 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.088989609-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/walk.go:14      4 +0x5d\n"}^M
18815 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089002061-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*planVisitor).visit      Internal(0xc000d1bb78, 0x47e7bc0, 0xc00c47a1e0, 0x3f9577a, 0x5)\n"}^M
18816 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089009499-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/walk.go:74      2 +0x2ac\n"}^M
18817 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.08904104-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*planVisitor).visit(      0xc000d1bb78, 0x47e7bc0, 0xc00c47a1e0, 0x6cd3518, 0x6cd3518)\n"}^M
18818 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089053683-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/walk.go:11      1 +0x8d\n"}^M
18819 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089061784-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.walkPlan(...)\n"}^M
18820 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089072845-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/walk.go:75      \n"}^M
18821 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089080484-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.startExec(0x47e5740,       0xc01da3e300, 0xc00011e580, 0xc00dd35cd0, 0x47e7bc0, 0xc00c47a1e0, 0x0, 0x2)\n"}^M
18822 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089091825-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/plan.go:43      5 +0x1bb\n"}^M
18823 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089099318-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*planNodeToRowSourc      e).Start(0xc000016500, 0x47e5740, 0xc01da3e300, 0x6cd5ca0, 0x398a680)\n"}^M
18824 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089106665-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/plan_node_      to_row_source.go:117 +0xd6\n"}^M
18825 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089114145-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql/execinfra.(*Processo      rBase).Run(0xc000016500, 0x47e5740, 0xc01da3e300)\n"}^M
18826 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089125616-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/execinfra/      processorsbase.go:747 +0x52\n"}^M
18827 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089140023-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql/flowinfra.(*FlowBase      ).Run(0xc1d9092240, 0x47e5740, 0xc01da3e300, 0x40dc200, 0x0, 0x0)\n"}^M
18828 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089148156-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/flowinfra/      flow.go:369 +0x24a\n"}^M
18829 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089155761-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).Ru      n(0xc01942ac60, 0xc005e70380, 0xc0388c5680, 0xc000d1c448, 0xc00a9ac900, 0xc00dd35dc0, 0x0, 0x0)\n"}^M
18830 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089162913-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/distsql_ru      nning.go:407 +0x5f1\n"}^M
18831 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089169894-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*DistSQLPlanner).Pl      anAndRun(0xc01942ac60, 0x47e5800, 0xc209b56c60, 0xc00dd35dc0, 0xc005e70380, 0xc0388c5680, 0x47e7bc0, 0xc00c47a1e0, 0xc00a9ac900, 0xc00dd35ac8)\n"}^M
18832 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.08919084-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/distsql_run      ning.go:1018 +0x225\n"}^M
18833 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089202062-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).exec      WithDistSQLEngine(0xc00dd35900, 0x47e5800, 0xc209b56c60, 0xc00dd35cd0, 0x2, 0x154d86d8d1e8, 0xc0e2aab880, 0xc000d1c700, 0xc0094fe3b8, 0x0, ...)\n"}^M
18834 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089210348-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_execu      tor_exec.go:909 +0x3f0\n"}^M
18835 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.08921812-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).dispa      tchToExecutionEngine(0xc00dd35900, 0x47e5800, 0xc209b56c60, 0xc00dd35cd0, 0x154d86d8d1e8, 0xc0e2aab880, 0x0, 0x0)\n"}^M
18836 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089226958-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_execu      tor_exec.go:800 +0x6cb\n"}^M
18837 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089235145-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).exec      StmtInOpenState(0xc00dd35900, 0x47e5800, 0xc209b56c60, 0x47fe980, 0xc0c2aa7900, 0xc00e11f53d, 0x25, 0x0, 0x1, 0x0, ...)\n"}^M
18838 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089246739-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_execu      tor_exec.go:488 +0xb09\n"}^M
18839 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089260185-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).exec      Stmt(0xc00dd35900, 0x47e5800, 0xc209b56c60, 0x47fe980, 0xc0c2aa7900, 0xc00e11f53d, 0x25, 0x0, 0x1, 0x0, ...)\n"}^M
18840 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089293289-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_execu      tor_exec.go:99 +0x4f6\n"}^M
18841 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089301256-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).exec      Cmd(0xc00dd35900, 0x47e5740, 0xc0129f6000, 0x0, 0x0)\n"}^M
18842 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089309051-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_execu      tor.go:1345 +0x1aa8\n"}^M
18843 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089317179-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run(      0xc00dd35900, 0x47e5740, 0xc0896cb180, 0xc01c2b4a00, 0x5400, 0x15000, 0xc01c2b4a98, 0xc149f639d0, 0x0, 0x0)\n"}^M
18844 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089329671-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_execu      tor.go:1274 +0x1f2\n"}^M
18845 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089337455-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn(      0xc015bd4000, 0x47e5740, 0xc0896cb180, 0xc00dd35900, 0x5400, 0x15000, 0xc01c2b4a98, 0xc149f639d0, 0x0, 0x0)\n"}^M
18846 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089345415-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_execu      tor.go:488 +0x104\n"}^M
18847 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089355842-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).proce      ssCommandsAsync.func1(0xc113fbebbd, 0xc0a4195f60, 0x47e5740, 0xc0896cb180, 0xc149f639d0, 0xc015bd4000, 0xc0e2aab200, 0x48088c0, 0xc21448aa50, 0xc006eb3140, ...)\n"}^M
18848 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089363922-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/con      n.go:591 +0x2e8\n"}^M
18849 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.08937127-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"created by github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*c      onn).processCommandsAsync\n"}^M
18850 [05:32:14] :             [run] {"Time":"2020-05-28T01:32:13.089381202-04:00","Action":"output","Package":"github.com/cockroachdb/cockroach/pkg/sql/logictest","Test":"TestSqlLiteLogic/local/slt_good_1.test#09","Output":"\t/go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/con      n.go:523 +0x17e\n"}^M

@asubiotto
Copy link
Contributor

Which limit do you mean?

@yuzefovich
Copy link
Member

I meant the time limit of 24 hours.

@asubiotto
Copy link
Contributor

Might be, but we've had successful runs of 12-18h so it would be a bit surprising. Although given that variance maybe a 24h run is to be expected?

@yuzefovich yuzefovich mentioned this issue Jun 2, 2020
Closed
@asubiotto
Copy link
Contributor

Let's focus on fixing DrainMeta/Next, allow short-circuiting in the hash joiner, and then circle back to this if it's still an issue.

@yuzefovich
Copy link
Member

DrainMeta/Next issue has been fixed, I think the next step is fixing Closers and then enabling the short-circuiting in the hash joiner. I'll assign the issue to @asubiotto since you're working on that.

@yuzefovich yuzefovich assigned asubiotto and unassigned yuzefovich Jun 25, 2020
@yuzefovich yuzefovich mentioned this issue Jul 13, 2020
Closed
@jordanlewis jordanlewis changed the title sql/logictest: TestSqlLiteLogic/local/slt_good_1.test#09 timed out colexec: re-enable short-circuiting of hash join Jul 28, 2020
@yuzefovich yuzefovich mentioned this issue Jul 28, 2020
Merged
@craig craig bot closed this as completed in 4de665c Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asubiotto asubiotto

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
20.2
Development

Successfully merging a pull request may close this issue.

colexec: re-enable short-circuiting in the hash joiner yuzefovich/cockroach
4 participants
@yuzefovich @asubiotto @cockroach-teamcity @andy-kimball