Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logictest: add option to strip prefix in kvtrace #49582

Closed
Tracked by #52617
asubiotto opened this issue May 27, 2020 · 0 comments · Fixed by #53020
Closed
Tracked by #52617

logictest: add option to strip prefix in kvtrace #49582

asubiotto opened this issue May 27, 2020 · 0 comments · Fixed by #53020
Assignees
@asubiotto
Labels
A-multitenancy Related to multi-tenancy C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@asubiotto
Copy link
Contributor

Some logic tests that test kvtraces (e.g. execbuilder/testdata/geospatial) fail when run under the 3node-tenant configuration because a tenant ID is prefixed to the keys. These types of tests could add a directive to strip a given prefix from keys so that they can be run under 3node-tenant.
@asubiotto asubiotto added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-multitenancy Related to multi-tenancy labels May 27, 2020
@asubiotto asubiotto self-assigned this Jun 2, 2020
@asubiotto asubiotto mentioned this issue Aug 11, 2020
Closed
10 tasks
@asubiotto asubiotto mentioned this issue Aug 19, 2020
Merged
@craig craig bot closed this as completed in c5fd3de Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asubiotto asubiotto

Labels
A-multitenancy Related to multi-tenancy C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

logictest: move remaining kv trace assertions to execbuilder tests
1 participant
@asubiotto