Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: put the output of EXPLAIN (VEC) in the EXPLAIN ANALYZE (DEBUG) bundle #47940

Closed
RaduBerinde opened this issue Apr 22, 2020 · 0 comments · Fixed by #61887
Closed

sql: put the output of EXPLAIN (VEC) in the EXPLAIN ANALYZE (DEBUG) bundle #47940

RaduBerinde opened this issue Apr 22, 2020 · 0 comments · Fixed by #61887
Assignees
Labels
A-sql-explain Issues related to EXPLAIN and EXPLAIN ANALYZE improvements

Comments

@RaduBerinde
Copy link
Member

EXPLAIN ANALYZE (DEBUG) generates a bundle which contains the output of most flavors of EXPLAIN, except EXPLAIN (VEC). I tried to add it but it looks very hard to integrate with. For example, the code messes with the subqueries in planner.curPlan:

outerSubqueries := params.p.curPlan.subqueryPlans

outerSubqueries := params.p.curPlan.subqueryPlans

I believe this code could use some cleanup. Also note that EXPLAIN (VEC) doesn't work when there are subqueries. But in the case of EXPLAIN ANALYZE (DEBUG) we actually run everything. So wecould conceivably generate it, perhaps separately for each subquery/postquery. This is what we do with the distsql diagrams: the bundle contains a separate diagram for each subquery/main query/postquery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-explain Issues related to EXPLAIN and EXPLAIN ANALYZE improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants