Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: tpchvec/perf failed #47118

Closed
cockroach-teamcity opened this issue Apr 7, 2020 · 1 comment · Fixed by #47134
Closed

roachtest: tpchvec/perf failed #47118

cockroach-teamcity opened this issue Apr 7, 2020 · 1 comment · Fixed by #47134
Assignees
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).tpchvec/perf failed on release-20.1@7699136a4861a6f6423e16ab7954fc4ac226bd6a:

The test failed on branch=release-20.1, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/20200407-1857166/tpchvec/perf/run_1
	tpchvec.go:644,tpchvec.go:659,test_runner.go:753: [q15] vec ON is slower by 15.33% than vec OFF
		vec ON times: [4.49 4.59 4.61]
		vec OFF times: [3.95 3.98 4.18]

More

Artifacts: /tpchvec/perf

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity cockroach-teamcity added branch-release-20.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Apr 7, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.1 milestone Apr 7, 2020
@yuzefovich yuzefovich assigned yuzefovich and unassigned andreimatei Apr 7, 2020
@yuzefovich
Copy link
Member

Here are the comparisons of the run times of query 15 for the last five days:

09:20:32 tpchvec.go:629: [q15] vec OFF was faster by 10.58%: 4.39s ON vs 3.97s OFF --- WARNING
09:04:26 tpchvec.go:629: [q15] vec OFF was faster by 9.98%: 4.41s ON vs 4.01s OFF --- WARNING
09:13:59 tpchvec.go:629: [q15] vec OFF was faster by 9.93%: 4.65s ON vs 4.23s OFF --- WARNING
09:16:37 tpchvec.go:629: [q15] vec OFF was faster by 12.11%: 4.63s ON vs 4.13s OFF --- WARNING
09:25:08 tpchvec.go:629: [q15] vec OFF was faster by 15.33%: 4.59s ON vs 3.98s OFF --- WARNING

Most of the time of this query spends in index join, and it seems to me that the overhead of columnarizer-materializer causes this slowdown. It doesn't seem like it is a regression due to recent commits, so I'll open up a PR to increase the slowness failure threshold from 15% to 20%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants