Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: circular dependency #45976

Closed
knz opened this issue Mar 11, 2020 · 2 comments · Fixed by #45977
Closed

Makefile: circular dependency #45976

knz opened this issue Mar 11, 2020 · 2 comments · Fixed by #45977
Labels
A-build-system S-3-productivity Severe issues that impede the productivity of CockroachDB developers.

Comments

@knz
Copy link
Contributor

knz commented Mar 11, 2020

I am currently debugging the Makefile because a fresh clone of the repo does not build any more.

The proximate symptom is that the vendor tree is not ready when the first Go target is being built.

I found the following:

  1. Makefile includes build/deps.mk
  2. build rule for deps.mk depends on deps.mk.sig
  3. build rule for deps.mk.sig depends on variable definitions in Makefile
  4. var defs depend on the contents of deps.mk being included at step (1)

It's because of the circular dependency (which make cannot resolve) that the target bin/.submodules-initialized does not get processed properly.

@knz
Copy link
Contributor Author

knz commented Mar 11, 2020

I am looking into this.

@knz
Copy link
Contributor Author

knz commented Mar 11, 2020

cc @petermattis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system S-3-productivity Severe issues that impede the productivity of CockroachDB developers.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant