sql: v19.2.2: assertion failed while validating a table descriptor

[cockroach-teamcity]

This issue was autofiled by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry link: https://sentry.io/organizations/cockroach-labs/issues/1501443489/?referrer=webhooks_plugin

Panic message:

*errors.errorString
*safedetails.withSafeDetails: parentID %d does not exist (1)
structured.go:1544: *withstack.withStack (2)
*assert.withAssertionFailure
(check the extra data payloads)

Stacktrace (expand for inline code snippets):

cockroach/pkg/sql/sqlbase/structured.go

Lines 1543 to 1545 in 3cbd056

	if !res.Exists() {
	return errors.AssertionFailedf("parentID %d does not exist", errors.Safe(desc.ParentID))
	}

in pkg/sql/sqlbase.(*TableDescriptor).validateCrossReferences

cockroach/pkg/sql/sqlbase/structured.go

Lines 1530 to 1532 in 3cbd056

	}
	return desc.validateCrossReferences(ctx, txn)
	}

in pkg/sql/sqlbase.(*TableDescriptor).Validate

cockroach/pkg/sql/descriptor.go

Lines 182 to 184 in 3cbd056

	if err := table.Validate(ctx, txn); err != nil {
	return err

in pkg/sql.getDescriptorByID

cockroach/pkg/sql/physical_schema_accessors.go

Lines 159 to 161 in 3cbd056

	desc := &sqlbase.TableDescriptor{}
	err = getDescriptorByID(ctx, txn, descID, desc)
	if err != nil {

in pkg/sql.UncachedPhysicalAccessor.GetObjectDesc

cockroach/pkg/sql/table.go

Lines 267 to 269 in 3cbd056

	phyAccessor := UncachedPhysicalAccessor{}
	obj, err := phyAccessor.GetObjectDesc(ctx, txn, tn, flags)
	if obj == nil {

in pkg/sql.(*TableCollection).getTableVersion.func1

cockroach/pkg/sql/table.go

Lines 275 to 277 in 3cbd056

	if avoidCache {
	return readTableFromStore()
	}

in pkg/sql.(*TableCollection).getTableVersion

cockroach/pkg/sql/physical_schema_accessors.go

Lines 237 to 239 in 3cbd056

	}
	table, err := a.tc.getTableVersion(ctx, txn, name, flags)
	if table == nil {

in pkg/sql.(*CachedPhysicalAccessor).GetObjectDesc

cockroach/pkg/sql/logical_schema_accessors.go

Lines 92 to 94 in 3cbd056

	// Fallthrough.
	return l.SchemaAccessor.GetObjectDesc(ctx, txn, name, flags)
	}

in pkg/sql.(*LogicalSchemaAccessor).GetObjectDesc

cockroach/pkg/sql/resolver.go

Lines 292 to 294 in 3cbd056

	lookupFlags.CommonLookupFlags = p.CommonLookupFlags(false /* required */)
	objDesc, err := sc.GetObjectDesc(ctx, p.txn, &p.tableName, lookupFlags)
	return objDesc != nil, objDesc, err

in pkg/sql.(*planner).LookupObject

cockroach/pkg/sql/sem/tree/name_resolution.go

Lines 279 to 281 in 3cbd056

	// Already 3 parts: nothing to search. Delegate to the resolver.
	return r.LookupObject(ctx, lookupFlags, t.Catalog(), t.Schema(), t.Table())
	}

in pkg/sql/sem/tree.(*TableName).ResolveExisting

cockroach/pkg/sql/resolver.go

Lines 140 to 142 in 3cbd056

	) (res tree.NameResolutionResult, err error) {
	found, descI, err := tn.ResolveExisting(ctx, sc, lookupFlags, sc.CurrentDatabase(), sc.CurrentSearchPath())
	if err != nil {

in pkg/sql.resolveExistingObjectImpl

cockroach/pkg/sql/resolver.go

Lines 101 to 103 in 3cbd056

	) (res *ImmutableTableDescriptor, err error) {
	desc, err := resolveExistingObjectImpl(ctx, sc, tn, lookupFlags, requiredType)
	if err != nil || desc == nil {

in pkg/sql.ResolveExistingObject

cockroach/pkg/sql/opt_catalog.go

Lines 168 to 170 in 3cbd056

	oc.tn = *name
	desc, err := ResolveExistingObject(ctx, oc.planner, &oc.tn, tree.ObjectLookupFlagsWithRequired(), ResolveAnyDescType)
	if err != nil {

in pkg/sql.(*optCatalog).ResolveDataSource

cockroach/pkg/sql/opt/optbuilder/util.go

Lines 475 to 477 in 3cbd056

	}
	ds, resName, err := b.catalog.ResolveDataSource(b.ctx, flags, tn)
	if err != nil {

in pkg/sql/opt/optbuilder.(*Builder).resolveDataSource

cockroach/pkg/sql/opt/optbuilder/util.go

Lines 453 to 455 in 3cbd056

	) (cat.Table, tree.TableName) {
	ds, resName := b.resolveDataSource(tn, priv)
	tab, ok := ds.(cat.Table)

in pkg/sql/opt/optbuilder.(*Builder).resolveTable

cockroach/pkg/sql/opt/optbuilder/insert.go

Lines 167 to 169 in 3cbd056

	// Find which table we're working on, check the permissions.
	tab, resName := b.resolveTable(tn, privilege.INSERT)
	if alias == nil {

in pkg/sql/opt/optbuilder.(*Builder).buildInsert

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 234 to 236 in 3cbd056

	case *tree.Insert:
	return b.buildInsert(stmt, inScope)

in pkg/sql/opt/optbuilder.(*Builder).buildStmt

cockroach/pkg/sql/opt/optbuilder/builder.go

Lines 184 to 186 in 3cbd056

	// and physical properties.
	outScope := b.buildStmt(b.stmt, nil /* desiredTypes */, b.allocScope())
	physical := outScope.makePhysicalProps()

in pkg/sql/opt/optbuilder.(*Builder).Build

cockroach/pkg/sql/plan_opt.go

Lines 418 to 420 in 3cbd056

	bld := optbuilder.New(ctx, &p.semaCtx, p.EvalContext(), &opc.catalog, f, opc.p.stmt.AST)
	if err := bld.Build(); err != nil {
	return nil, err

in pkg/sql.(*optPlanningCtx).buildExecMemo

cockroach/pkg/sql/plan_opt.go

Lines 160 to 162 in 3cbd056

	execMemo, err := opc.buildExecMemo(ctx)
	if err != nil {

in pkg/sql.(*planner).makeOptimizerPlan

cockroach/pkg/sql/conn_executor_exec.go

Lines 742 to 744 in 3cbd056

	log.VEvent(ctx, 2, "generating optimizer plan")
	if err := planner.makeOptimizerPlan(ctx); err != nil {
	log.VEventf(ctx, 1, "optimizer plan failed: %v", err)

in pkg/sql.(*connExecutor).makeExecPlan

cockroach/pkg/sql/conn_executor_exec.go

Lines 624 to 626 in 3cbd056

	// between here and there needs to happen even if there's an error.
	err := ex.makeExecPlan(ctx, planner)
	// We'll be closing the plan manually below after execution; this

in pkg/sql.(*connExecutor).dispatchToExecutionEngine

cockroach/pkg/sql/conn_executor_exec.go

Lines 415 to 417 in 3cbd056

	p.autoCommit = os.ImplicitTxn.Get() && !ex.server.cfg.TestingKnobs.DisableAutoCommit
	if err := ex.dispatchToExecutionEngine(ctx, p, res); err != nil {
	return nil, nil, err

in pkg/sql.(*connExecutor).execStmtInOpenState

cockroach/pkg/sql/conn_executor_exec.go

Lines 97 to 99 in 3cbd056

	} else {
	ev, payload, err = ex.execStmtInOpenState(ctx, stmt, res, pinfo)
	}

in pkg/sql.(*connExecutor).execStmt

cockroach/pkg/sql/conn_executor.go

Lines 1242 to 1244 in 3cbd056

	stmtCtx := withStatement(ctx, ex.curStmt)
	ev, payload, err = ex.execStmt(stmtCtx, curStmt, stmtRes, nil /* pinfo */)
	if err != nil {

in pkg/sql.(*connExecutor).execCmd

cockroach/pkg/sql/conn_executor.go

Lines 1171 to 1173 in 3cbd056

	var err error
	if err = ex.execCmd(ex.Ctx()); err != nil {
	if err == io.EOF || err == errDrainingComplete {

in pkg/sql.(*connExecutor).run

cockroach/pkg/sql/internal.go

Lines 201 to 203 in 3cbd056

	go func() {
	if err := ex.run(ctx, ie.mon, mon.BoundAccount{} /*reserved*/, nil /* cancel */); err != nil {
	ex.recordError(ctx, err)

in pkg/sql.(*internalExecutorImpl).initConnEx.func1
/usr/local/go/src/runtime/asm_amd64.s#L1336-L1338 in runtime.goexit

pkg/sql/sqlbase/structured.go in pkg/sql/sqlbase.(*TableDescriptor).validateCrossReferences at line 1544
pkg/sql/sqlbase/structured.go in pkg/sql/sqlbase.(*TableDescriptor).Validate at line 1531
pkg/sql/descriptor.go in pkg/sql.getDescriptorByID at line 183
pkg/sql/physical_schema_accessors.go in pkg/sql.UncachedPhysicalAccessor.GetObjectDesc at line 160
pkg/sql/table.go in pkg/sql.(*TableCollection).getTableVersion.func1 at line 268
pkg/sql/table.go in pkg/sql.(*TableCollection).getTableVersion at line 276
pkg/sql/physical_schema_accessors.go in pkg/sql.(*CachedPhysicalAccessor).GetObjectDesc at line 238
pkg/sql/logical_schema_accessors.go in pkg/sql.(*LogicalSchemaAccessor).GetObjectDesc at line 93
pkg/sql/resolver.go in pkg/sql.(*planner).LookupObject at line 293
pkg/sql/sem/tree/name_resolution.go in pkg/sql/sem/tree.(*TableName).ResolveExisting at line 280
pkg/sql/resolver.go in pkg/sql.resolveExistingObjectImpl at line 141
pkg/sql/resolver.go in pkg/sql.ResolveExistingObject at line 102
pkg/sql/opt_catalog.go in pkg/sql.(*optCatalog).ResolveDataSource at line 169
pkg/sql/opt/optbuilder/util.go in pkg/sql/opt/optbuilder.(*Builder).resolveDataSource at line 476
pkg/sql/opt/optbuilder/util.go in pkg/sql/opt/optbuilder.(*Builder).resolveTable at line 454
pkg/sql/opt/optbuilder/insert.go in pkg/sql/opt/optbuilder.(*Builder).buildInsert at line 168
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).buildStmt at line 235
pkg/sql/opt/optbuilder/builder.go in pkg/sql/opt/optbuilder.(*Builder).Build at line 185
pkg/sql/plan_opt.go in pkg/sql.(*optPlanningCtx).buildExecMemo at line 419
pkg/sql/plan_opt.go in pkg/sql.(*planner).makeOptimizerPlan at line 161
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).makeExecPlan at line 743
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).dispatchToExecutionEngine at line 625
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execStmtInOpenState at line 416
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execStmt at line 98
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).execCmd at line 1243
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).run at line 1172
pkg/sql/internal.go in pkg/sql.(*internalExecutorImpl).initConnEx.func1 at line 202
/usr/local/go/src/runtime/asm_amd64.s in runtime.goexit at line 1337

Tag	Value
Cockroach Release	v19.2.2
Cockroach SHA:	3cbd056
Platform	linux amd64
Distribution	CCL
Environment	v19.2.2
Command	server
Go Version	go1.12.12
# of CPUs	4
# of Goroutines	1784

[yuzefovich]

cc @otan I think you've been looking at some (maybe) related code recently.

[ajwerner]

I think this is #50997 which we backported to 20.1 but not to 19.2. I'm closing this and somebody can re-open it if they feel like that backport is in order.