Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Errors in SQL Client #43994

Closed
cchhxxttxs opened this issue Jan 15, 2020 · 4 comments · Fixed by #66079
Closed

Display Errors in SQL Client #43994

cchhxxttxs opened this issue Jan 15, 2020 · 4 comments · Fixed by #66079
Labels
C-investigation Further steps needed to qualify. C-label will change.

Comments

@cchhxxttxs
Copy link

Describe the problem

  1. Chinese characters display wrong in ARRAY TYPE;
  2. TIME‘s types display in the same way.

To Reproduce
MY SET:
cockroach start --insecure
cockroach sql --insecure

ERRORS:
e.g. SELECT ARRAY['哈哈', '呵呵', '吼吼'];
array
+------------------------------------------------------------------------------+
{\345\223\210\345\223\210,\345\221\265\345\221\265,\345\220\274\345\220\274}
(1 row)

e.g.
SELECT '2019-03-21 21:12:12'::TIME;
time
+---------------------------+
0000-01-01 21:12:12+00:00
(1 row)
SELECT '2019-03-21 21:12:12'::DATE;
date
+---------------------------+
2019-03-21 00:00:00+00:00
(1 row)
SELECT '2019-03-21 21:12:12'::TIMESTAMP;
timestamp
+---------------------------+
2019-03-21 21:12:12+00:00
(1 row)

Expected behavior

  1. Chinese characters in ARRAY TYPE display right ;
  2. TIME‘s types display in right ways.

Environment:

  • CockroachDB version: v19.1.3
  • Server OS: Linux
  • Client app: cockroach sql --insecure
@awoods187 awoods187 added the C-investigation Further steps needed to qualify. C-label will change. label Apr 9, 2020
@awoods187
Copy link
Contributor

@otan is this time portion fixed? Or is it the same libpq problem?

@otan
Copy link
Contributor

otan commented Apr 9, 2020

this is lib/pq on both fronts and is a display issue only. the underlying value in both is correct if you tried fetching it from other drivers/ORMs. would probably close this and move it under the pgx umbrella task.

@otan otan removed their assignment Apr 9, 2020
@awoods187
Copy link
Contributor

Makes sense--thanks!

@knz
Copy link
Contributor

knz commented Jun 4, 2021

We had fixed the display of times in v21.1 already. Doing the arrays in #66079.

@craig craig bot closed this as completed in 97c4ad3 Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-investigation Further steps needed to qualify. C-label will change.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants