Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Upgrade React version in the admin UI #43361

Closed
piyush-singh opened this issue Dec 19, 2019 · 1 comment
Closed

ui: Upgrade React version in the admin UI #43361

piyush-singh opened this issue Dec 19, 2019 · 1 comment
Assignees
@koorosh
Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@piyush-singh
Copy link

piyush-singh commented Dec 19, 2019 •
edited by nathanstilwell
Loading

In preparation to share components between cockroach applications, React dependencies should be upgraded to maximize compatibility. Currently (as of 19-12-2019) CockroachCloud is on react version 16.8.0 and Admin UI is using version 16.3.1. Looking at the changelog I would guess an upgrade would not be too intrusive, but part of this task will be to evaluate that.

dep admin-ui cloud
react ^16.3.1 ^16.8.0
react-dom 16.4.2 ^16.8.0

Also, be aware that updating the version of react may effect other dependencies (react-motion, react-paginate, react-copy-to-clipboard, etc)
@piyush-singh piyush-singh added the A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. label Dec 19, 2019
@nathanstilwell nathanstilwell added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Dec 19, 2019
@dhartunian
Copy link
Collaborator

This was done in #43846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koorosh koorosh

Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nathanstilwell @dhartunian @koorosh @piyush-singh