Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: deleting a user or changing their password does not revoke web sessions #42466

Closed
mberhault opened this issue Nov 13, 2019 · 3 comments
Closed
Assignees

Comments

@mberhault
Copy link
Contributor

mberhault commented Nov 13, 2019

Version: v19.2.0

Steps to reproduce:

  1. start a cluster
  2. create a sql user foo with a password
  3. login to the admin UI as user foo
  4. change foo's password through SQL
  5. navigating the admin UI continues to work
  6. delete user foo through SQL
  7. navigating the admin UI continues to work

This is incorrect. In both "change password" and "delete user", the web sessions for the associated user should be revoked immediately, causing any use of the admin UI to redirect to the login page.

Epic: CRDB-26131

@piyush-singh
Copy link

Yikes, not sure how this was missed. Thanks Nathan. cc @dhartunian - I just repro'd this in cockroach demo in a few seconds. We should probably add this to our list for 20.1.1, and I think take some of the lower priority items of the list. This is probably worth backporting to 19.2 and 19.1 as well, where I assume it is also an issue.

@knz
Copy link
Contributor

knz commented May 15, 2020

this may be a dup of #20718

@knz
Copy link
Contributor

knz commented May 15, 2020

Yeah it's a dup - folding into it #20718

@knz knz closed this as completed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants