-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teamcity/example-orms: example-orms isn't a pinned revision when running CI #42083
Comments
@apantel I think this is related to the work you are doing with pinning versions |
I don't think we'll prioritize this work. For the past few years, this issue hasn't caused much disruption. The way we workaround it is to teach examples-orms about which CRDB versions various tests are expected to work with. Example: https://github.com/cockroachdb/examples-orms/blob/1e65311aeebffed07371d258bfcf7fbe4abf01c8/testing/main_test.go#L191-L194 |
#42042, a backport to
release-v2.1
was failing on TC due to Example ORM tests. Debugging that I noticed that our TC setup does not use a pinned revision of example-orms when running the test suite (it simply picks up whatever is onmaster
). This means that any and every change pushed out to https://github.com/cockroachdb/examples-orms is what gets used for all future TC runs against all branches (including all the way back torelease-v2.1
). This is probably not what we want (#42042 (comment)).Jira issue: CRDB-5389
The text was updated successfully, but these errors were encountered: