Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: fix and re-enable rocksdb assertions #39564

Closed
tbg opened this issue Aug 12, 2019 · 2 comments
Closed

storage: fix and re-enable rocksdb assertions #39564

tbg opened this issue Aug 12, 2019 · 2 comments
Assignees
@ajkr @nvanbenschoten @jeffrey-xiao
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@tbg
Copy link
Member

tbg commented Aug 12, 2019

We just had to disable them again since they fail to re-establish some amount of sanity on master. We need to fix the underlying problems and reenable the assertions ASAP.

#39562
@tbg tbg added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Aug 12, 2019
@tbg tbg mentioned this issue Aug 12, 2019
Merged
@ajkr
Copy link
Contributor

ajkr commented Aug 13, 2019 •
edited
Loading

My preferred solution is facebook/rocksdb#5539. I am fine waiting and seeing if it gets merged before backporting it and reenabling assertions.

@ajkr
Copy link
Contributor

ajkr commented Nov 5, 2019

Fixed by #41153.

@ajkr ajkr closed this as completed Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajkr ajkr

@nvanbenschoten nvanbenschoten

@jeffrey-xiao jeffrey-xiao

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ajkr @tbg @nvanbenschoten @jeffrey-xiao