Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: large dates and timestamps are silently changed #37508

Closed
maddyblue opened this issue May 14, 2019 · 5 comments
Closed

cdc: large dates and timestamps are silently changed #37508

maddyblue opened this issue May 14, 2019 · 5 comments
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cdc

Comments

@maddyblue
Copy link
Contributor

maddyblue commented May 14, 2019 •
edited by cockroach-jira-scripts
Loading

The goavro library uses int32s when marshaling dates and timestamps. If they don't fit in that size they are silently truncated.

Jira issue: CRDB-4426
@maddyblue maddyblue added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label May 14, 2019
@danhhz danhhz added the A-cdc Change Data Capture label May 14, 2019
@danhhz danhhz removed their assignment May 14, 2019
@maddyblue
Copy link
Contributor Author

This may actually be a problem with the call to .UnixNano, suggesting that goavro only handles dates and timestamps whose nanosecond representation fits in an int64.

@rolandcrosby rolandcrosby mentioned this issue Jun 4, 2019
Closed
@shermanCRL shermanCRL mentioned this issue Jan 15, 2021
Closed
@amruss
Copy link
Contributor

amruss commented May 4, 2022

@HonoreDB do we think this is still an issue? Otherwise lets close

@HonoreDB
Copy link
Contributor

HonoreDB commented May 4, 2022

I'll look into it, I know goavro's improved their date handling on recent versions but they may not have fixed this.

@miretskiy
Copy link
Contributor

@HonoreDB please close this issue if it's stale.

@miretskiy
Copy link
Contributor

Close/stale -- will reopen if somebody complains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cdc Change Data Capture C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cdc
Projects
No open projects
[DEPRECATED] CDC
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
7 participants
@maddyblue @danhhz @jlinder @HonoreDB @amruss @miretskiy @elinorgarcia