Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: cluster setting errors should list valid values #35477

Closed
BramGruneir opened this issue Mar 6, 2019 · 1 comment · Fixed by #46932
Closed

sql: cluster setting errors should list valid values #35477

BramGruneir opened this issue Mar 6, 2019 · 1 comment · Fixed by #46932
Assignees
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-productivity Severe issues that impede the productivity of CockroachDB developers. S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.

Comments

@BramGruneir
Copy link
Member

This would be incredibly useful for enum settings. e.g.

root@:26257/defaultdb> set cluster setting server.remote_debugging.mode = always;
pq: invalid mode: 'always'
root@:26257/defaultdb> set cluster setting server.remote_debugging.mode = on;
pq: invalid mode: 'on'
root@:26257/defaultdb> set cluster setting server.remote_debugging.mode = true;
pq: argument of SET CLUSTER SETTING server.remote_debugging.mode must be type string, not type bool
root@:26257/defaultdb> set cluster setting server.remote_debugging.mode = 'true';
invalid syntax: statement ignored: driver: bad connection
warning: connection lost!
opening new connection: all session settings will be lost
warning: error retrieving the transaction status: dial tcp [::1]:26257: connect: connection refused
warning: connection lost!
opening new connection: all session settings will be lost
warning: error retrieving the database name: dial tcp [::1]:26257: connect: connection refused
root@:26257/? ?> set cluster setting server.remote_debugging.mode = 'true';
warning: connection lost!
opening new connection: all session settings will be lost
pq: invalid mode: 'true'
root@:26257/defaultdb> set cluster setting server.remote_debugging.mode = 'true';
pq: invalid mode: 'true'
root@:26257/defaultdb> set cluster setting server.remote_debugging.mode = 'always';
pq: invalid mode: 'always'
root@:26257/defaultdb> show cluster setting server.remote_debuggin.mode;
pq: unknown setting: "server.remote_debuggin.mode"
root@:26257/defaultdb> show cluster setting server.remote_debugging.mode;
  server.remote_debugging.mode

@knz for triage

@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-productivity Severe issues that impede the productivity of CockroachDB developers. and removed C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Mar 7, 2019
@jordanlewis
Copy link
Member

@BramGruneir this would probably take you 10 minutes to implement - want to take care of it real quick?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) S-3-productivity Severe issues that impede the productivity of CockroachDB developers. S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants