Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to go 1.12 #35197

Closed
3 of 4 tasks
nvanbenschoten opened this issue Feb 26, 2019 · 2 comments
Closed
3 of 4 tasks

build: upgrade to go 1.12 #35197

nvanbenschoten opened this issue Feb 26, 2019 · 2 comments
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@nvanbenschoten
Copy link
Member

nvanbenschoten commented Feb 26, 2019

NOTE: We are not planning on upgrading for the 19.1 release.

Known issues:

@awoods187 awoods187 added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Mar 6, 2019
@bdarnell
Copy link
Contributor

Even though 19.2 will be the first CockroachDB release to officially build with Go 1.12, we should probably backport the changes here to our supported release branches (at least 2.1 and 19.1) for developer convenience (so that people who have upgraded to newer go versions don't have to maintain a separate toolchain or work entirely in docker).

@dt dt mentioned this issue Apr 3, 2019
5 tasks
@knz
Copy link
Contributor

knz commented Apr 3, 2019

Folded into #35637.

@knz knz closed this as completed Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Development

No branches or pull requests

4 participants