Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: support timezone abbreviations in date parsing #31710

Closed
bobvawter opened this issue Oct 22, 2018 · 2 comments
Closed

sql: support timezone abbreviations in date parsing #31710

bobvawter opened this issue Oct 22, 2018 · 2 comments
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale

Comments

@bobvawter
Copy link
Contributor

We don't support the use of "PST" or other abbreviations when parsing timezone values. This requires access to more tzinfo fields than are readily available in the time package to resolve a candidate timezone.

If this is implemented, look at:

@bobvawter bobvawter added A-sql-pgcompat Semantic compatibility with PostgreSQL S-3 Medium-low impact: incurs increased costs for some users (incl lower avail, recoverable bad data) labels Oct 22, 2018
@petermattis petermattis added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Oct 28, 2018
@knz knz removed the S-3 Medium-low impact: incurs increased costs for some users (incl lower avail, recoverable bad data) label Nov 12, 2018
@knz knz changed the title Support timezone abbreviations in date parsing sql: support timezone abbreviations in date parsing Nov 12, 2018
@bdarnell
Copy link
Contributor

Note that these short abbreviations are ambiguous. For example, the abbreviation IST is used by India, Ireland, and Israel. Therefore it's not just a matter of getting more information from the tzdata files, we need a plan to handle the ambiguity.

Postgres makes this configurable: https://www.postgresql.org/docs/current/datetime-config-files.html

@github-actions
Copy link

github-actions bot commented Jun 5, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) no-issue-activity X-stale
Projects
None yet
Development

No branches or pull requests

4 participants