Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: investigate zone config behaviour during dropping of a {table,database} #30375

Closed
justinj opened this issue Sep 18, 2018 · 7 comments
Closed
Labels
A-schema-changes C-investigation Further steps needed to qualify. C-label will change.

Comments

@justinj
Copy link
Contributor

justinj commented Sep 18, 2018

@nvanbenschoten and I were attempting to drop a database with a GC TTL of 30 seconds, but after we dropped it, it seemed that the zone config we had set up no longer applied, so it fell back to the .default zone config. We should clarify and document if this is the actual expected behaviour in this kind of situation.

cc @knz

@justinj justinj added the C-investigation Further steps needed to qualify. C-label will change. label Sep 18, 2018
@knz knz added the A-kv-distribution Relating to rebalancing and leasing. label Sep 18, 2018
@knz
Copy link
Contributor

knz commented Sep 18, 2018

This needs to cross-reference #28901.

@a-robinson
Copy link
Contributor

I think this is a dupe of #24179?

@petermattis
Copy link
Collaborator

@knz Can you elaborate why this is a core issue? It feels like this is something under the control of the schema change folks. In particular, it seems like dropping a database should not delete the associated zone config until all of the table drops have completed.

Cc @vivekmenezes

@knz
Copy link
Contributor

knz commented Sep 18, 2018

oh in my mind the application of zones to ranges is a matter of the replication layer.

Maybe the thing is cross-layer actually.

@vivekmenezes vivekmenezes removed the A-kv-distribution Relating to rebalancing and leasing. label Sep 18, 2018
@petermattis
Copy link
Collaborator

Yeah, it's possible it is cross layer. My guess from reading this issue and knowing a bit of the code is that the problem (or UX surprise) is in the schema change handling. Assigning to @vivekmenezes for more detailed diagnosis.

@vivekmenezes
Copy link
Contributor

This issue couldn't be resolved originally because the database descriptor would get dropped immediately. But now with the creation of a job for the DROP DATABASE being done for #19004
we can have the job delete the zone config after it has completed dropping all the table data.

@vivekmenezes vivekmenezes removed their assignment Sep 18, 2018
@vivekmenezes
Copy link
Contributor

this is a dup of #24179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-schema-changes C-investigation Further steps needed to qualify. C-label will change.
Projects
None yet
Development

No branches or pull requests

5 participants