Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importccl: IMPORT PGDUMP does not import views #29039

Closed
rytaft opened this issue Aug 24, 2018 · 2 comments
Closed

importccl: IMPORT PGDUMP does not import views #29039

rytaft opened this issue Aug 24, 2018 · 2 comments
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-qa T-disaster-recovery

Comments

@rytaft
Copy link
Collaborator

rytaft commented Aug 24, 2018

None of the IMPORT PGDUMP variants import views from the pg_dump file. This seems like something that should be supported, since the syntax for Postgres views is the same as CockroachDB views. If it can't be supported, that should probably be added to the docs as a limitation.

This was found as part of QA for #28158.

@rytaft rytaft added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-disaster-recovery O-qa labels Aug 24, 2018
@mokaixu mokaixu self-assigned this Nov 19, 2020
@dt dt unassigned mokaixu Jun 1, 2021
@shermanCRL
Copy link
Contributor

It’s possible we’ll get this ‘for free’ if we refactor IMPORT to hand off all DDL to SQL. We’ll close this for now, since we won’t act on this specific issue.

@steve-taylor
Copy link

t’s possible we’ll get this ‘for free’ if we refactor IMPORT to hand off all DDL to SQL.

This should also be done for indexes and sequences. The import will fail if there are any expression indexes. Sequences outright fail the import because it expects nextval and setval to prefix quoted sequence names with public.. I had to rip out those DDL statements and manually execute them after the import, which should be automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-qa T-disaster-recovery
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants