Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracer: data race with multi-cpu #2827

Closed
bdarnell opened this issue Oct 13, 2015 · 2 comments
Closed

Tracer: data race with multi-cpu #2827

bdarnell opened this issue Oct 13, 2015 · 2 comments
Assignees

Comments

@bdarnell
Copy link
Contributor

This happened in TestStoreRangeRebalance (and CPUS=2) but I don't think the particular test really matters.

==================
WARNING: DATA RACE
Read by goroutine 156:
  github.com/cockroachdb/cockroach/util/tracer.(*Trace).epoch()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/util/tracer/tracer.go:105 +0x45
  github.com/cockroachdb/cockroach/util/tracer.(*Trace).Epoch()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/util/tracer/tracer.go:101 +0x5f
  github.com/cockroachdb/cockroach/storage.(*Replica).processRaftCommand()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/replica.go:920 +0x2a6
  github.com/cockroachdb/cockroach/storage.(*Store).processRaft.func1()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/store.go:1517 +0xdd1
  github.com/cockroachdb/cockroach/util/stop.(*Stopper).RunWorker.func1()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/util/stop/stopper.go:88 +0x5f

Previous write by goroutine 206:
  github.com/cockroachdb/cockroach/util/tracer.(*Trace).epoch.func1()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/util/tracer/tracer.go:117 +0x2f5
  github.com/cockroachdb/cockroach/storage.(*Replica).addWriteCmd()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/replica.go:862 +0x947
  github.com/cockroachdb/cockroach/storage.(*Replica).resolveIntents.func1()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/replica.go:1471 +0x413
  github.com/cockroachdb/cockroach/util/stop.(*Stopper).RunAsyncTask.func1()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/util/stop/stopper.go:130 +0x65

Goroutine 156 (running) created at:
  github.com/cockroachdb/cockroach/util/stop.(*Stopper).RunWorker()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/util/stop/stopper.go:89 +0x6f
  github.com/cockroachdb/cockroach/storage.(*Store).processRaft()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/store.go:1534 +0xb6
  github.com/cockroachdb/cockroach/storage.(*Store).Start()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/store.go:540 +0x109a
  github.com/cockroachdb/cockroach/storage_test.(*multiTestContext).addStore()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/client_test.go:367 +0xb82
  github.com/cockroachdb/cockroach/storage_test.(*multiTestContext).Start()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/client_test.go:212 +0x15cf
  github.com/cockroachdb/cockroach/storage_test.TestStoreRangeRebalance()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/client_raft_test.go:1227 +0x2ac
  testing.tRunner()
      /opt/local/lib/go/src/testing/testing.go:456 +0xdc

Goroutine 206 (finished) created at:
  github.com/cockroachdb/cockroach/util/stop.(*Stopper).RunAsyncTask()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/util/stop/stopper.go:131 +0x270
  github.com/cockroachdb/cockroach/storage.(*Replica).resolveIntents()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/replica.go:1494 +0x8e7
  github.com/cockroachdb/cockroach/storage.(*Store).resolveWriteIntentError()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/store.go:1404 +0x1224
  github.com/cockroachdb/cockroach/storage.(*Store).Send()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/store.go:1245 +0x1006
  github.com/cockroachdb/cockroach/kv.(*LocalSender).Send()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/kv/local_sender.go:153 +0x444
  github.com/cockroachdb/cockroach/storage_test.(*multiTestContext).rpcSend()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/client_test.go:279 +0x4b5
  github.com/cockroachdb/cockroach/storage_test.(*multiTestContext).(github.com/cockroachdb/cockroach/storage_test.rpcSend)-fm()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/client_test.go:205 +0x115
  github.com/cockroachdb/cockroach/kv.(*DistSender).sendRPC()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/kv/dist_sender.go:372 +0x822
  github.com/cockroachdb/cockroach/kv.(*DistSender).sendAttempt()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/kv/dist_sender.go:443 +0x243
  github.com/cockroachdb/cockroach/kv.(*DistSender).sendChunk.func1()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/kv/dist_sender.go:550 +0x58d
  github.com/cockroachdb/cockroach/kv.(*DistSender).sendChunk()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/kv/dist_sender.go:558 +0x14f9
  github.com/cockroachdb/cockroach/kv.(*DistSender).(github.com/cockroachdb/cockroach/kv.sendChunk)-fm()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/kv/dist_sender.go:470 +0x64
  github.com/cockroachdb/cockroach/kv.(*chunkingSender).Send()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/kv/batch.go:185 +0x395
  github.com/cockroachdb/cockroach/kv.(*DistSender).Send()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/kv/dist_sender.go:470 +0x2c1
  github.com/cockroachdb/cockroach/kv.(*TxnCoordSender).Send()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/kv/txn_coord_sender.go:395 +0x11c1
  github.com/cockroachdb/cockroach/client.(*DB).send()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/client/db.go:478 +0x289
  github.com/cockroachdb/cockroach/client.(*DB).(github.com/cockroachdb/cockroach/client.send)-fm()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/client/db.go:448 +0x4b
  github.com/cockroachdb/cockroach/client.sendAndFill()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/client/db.go:414 +0x7c
  github.com/cockroachdb/cockroach/client.(*DB).RunWithResponse()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/client/db.go:448 +0xd2
  github.com/cockroachdb/cockroach/storage_test.getRangeMetadata()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/client_raft_test.go:588 +0x2f8
  github.com/cockroachdb/cockroach/storage_test.TestStoreRangeRebalance()
      /Users/bdarnell/work/cockroach/src/github.com/cockroachdb/cockroach/storage/client_raft_test.go:1264 +0xcaa
  testing.tRunner()
      /opt/local/lib/go/src/testing/testing.go:456 +0xdc
==================
@tbg tbg self-assigned this Oct 13, 2015
@bdarnell
Copy link
Contributor Author

Looks like a duplicate of #2593

@tbg
Copy link
Member

tbg commented Oct 14, 2015

agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants