Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: sequences: support AS <datatype> #25110

Closed
vilterp opened this issue Apr 26, 2018 · 3 comments · Fixed by #57339
Closed

sql: sequences: support AS <datatype> #25110

vilterp opened this issue Apr 26, 2018 · 3 comments · Fixed by #57339
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-sequences Sequence handling in SQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) X-anchored-telemetry The issue number is anchored by telemetry references.

Comments

@vilterp
Copy link
Contributor

vilterp commented Apr 26, 2018 •
edited
Loading

Currently fails to parse with an unimplemented error:

cockroach/pkg/sql/parser/sql.y

Line 3935 in fef4d74

AS typename { return unimplemented(sqllex, "create sequence AS option") }

and we always create the sequence as an int64.
@vilterp vilterp added the A-sql-sequences Sequence handling in SQL label Apr 26, 2018
@jordanlewis jordanlewis added A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) labels Apr 27, 2018
@awoods187 awoods187 mentioned this issue Oct 29, 2018
Closed
22 tasks
@knz knz added the X-anchored-telemetry The issue number is anchored by telemetry references. label Nov 22, 2018
@mokaixu mokaixu self-assigned this Dec 1, 2020
@mokaixu mokaixu mentioned this issue Dec 3, 2020
Merged
@blathers-crl blathers-crl bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Nov 17, 2021
@vy-ton
Copy link
Contributor

vy-ton commented Nov 17, 2021

@rafiss Moving to SQL Experience triage since this was on a closed project. This shows up as a top unimplemented feature on Serverless. I also see some activity on the linked PR :)

@craig craig bot closed this as completed in 2364527 Nov 18, 2021
@Jolg42
Copy link

Jolg42 commented Dec 7, 2021 •
edited
Loading

It's indeed a thing on serverless v21.2.0-beta.4 as of today, any idea when it will fixed on the live clusters?

@vy-ton
Copy link
Contributor

vy-ton commented Dec 7, 2021

This will be available with 22.1, our first release in 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-sequences Sequence handling in SQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) X-anchored-telemetry The issue number is anchored by telemetry references.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: Added CREATE SEQUENCE ... AS <typename> option. mokaixu/cockroach
6 participants
@vilterp @jordanlewis @knz @Jolg42 @vy-ton @mokaixu