Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: enhance SQL errors + make them reportable #24108

Closed
5 tasks
knz opened this issue Mar 21, 2018 · 4 comments
Closed
5 tasks

sql: enhance SQL errors + make them reportable #24108

knz opened this issue Mar 21, 2018 · 4 comments
Assignees
Labels
A-sql-execution Relating to SQL execution. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. meta-issue Contains a list of several other issues.

Comments

@knz
Copy link
Contributor

knz commented Mar 21, 2018

This is a sub-issue of #15854 and re-phrases actionable items for 2.1:

  • audit the SQL package for errors constructed by other means than using the pgerror constructors; convert any remaining errors accordingly.
  • audit the SQL package for "leaf" uses of 3rd-party packages that can generate non-pgerror errors, and add suitable pgerror wrapper. This can be automated with a linter.
  • modify the pgerror error constructors so that sensitive and non-sensitive information can be distinguished from each other (defined so that non-annotated info is considered sensitive by default)
  • make the data collection by app_stats.go + reporting able to report non-sensitive data
  • (main item from log+sql+reporting: enhance the auto reporting of issues #15854): in pgwire detect any remaining non-pgerror errors and convert them to "internal server error" so that users become less surprised.
@knz knz added this to the 2.1 milestone Mar 21, 2018
@knz
Copy link
Contributor Author

knz commented Mar 21, 2018

@vivekmenezes this is a work item that is driven by a user story but requires cross-team work at multiple levels (across the entire SQL layer of CockroachDB). So I added it to at least two projects that I think are relevant.

I probably would like to be involved; I think @dt was interested to look into this, and perhaps Bram will be as well.

@knz knz assigned dt and knz Mar 21, 2018
@knz
Copy link
Contributor Author

knz commented Mar 21, 2018

Assigning according to airtable; this assignment may change as the roadmap gets further refined.

@jordanlewis jordanlewis added the meta-issue Contains a list of several other issues. label Apr 24, 2018
@knz knz added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label May 14, 2018
@knz knz added the A-sql-execution Relating to SQL execution. label Jun 12, 2018
@knz knz modified the milestones: 2.1, 2.2 Aug 31, 2018
@petermattis petermattis removed this from the 2.2 milestone Oct 5, 2018
@dt dt removed their assignment Oct 9, 2018
@knz
Copy link
Contributor Author

knz commented May 6, 2019

(still working on this, see #36987)

@knz
Copy link
Contributor Author

knz commented Mar 26, 2021

This work has been completed.

@knz knz closed this as completed Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-execution Relating to SQL execution. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. meta-issue Contains a list of several other issues.
Projects
None yet
Development

No branches or pull requests

4 participants