Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli/gen: Decommissioned nodes are included in gen haproxy output #19863

Closed
andzdroid opened this issue Nov 7, 2017 · 1 comment · Fixed by #43908
Closed

cli/gen: Decommissioned nodes are included in gen haproxy output #19863

andzdroid opened this issue Nov 7, 2017 · 1 comment · Fixed by #43908
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-community Originated from the community S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.

Comments

@andzdroid
Copy link

andzdroid commented Nov 7, 2017 •
edited by knz
Loading

When I run cockroach gen haproxy, decommissioned nodes are included in the server list. They should be removed.
@couchand couchand added the S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption. label Nov 7, 2017
@couchand
Copy link
Contributor

couchand commented Nov 7, 2017

Likely related to #15609

@couchand couchand changed the title Decommissioned nodes are included in gen haproxy output cli: Decommissioned nodes are included in gen haproxy output Nov 7, 2017
@dianasaur323 dianasaur323 added this to the 1.2 milestone Nov 7, 2017
@tbg tbg mentioned this issue Dec 12, 2017
Closed
@bdarnell bdarnell modified the milestones: 2.0, Later Feb 8, 2018
@knz knz changed the title cli: Decommissioned nodes are included in gen haproxy output cli/gen: Decommissioned nodes are included in gen haproxy output Apr 11, 2018
@knz knz added O-community Originated from the community and removed community-answered labels Apr 11, 2018
@knz knz added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Apr 27, 2018
@tbg tbg added the A-cli label May 15, 2018
@petermattis petermattis removed this from the Later milestone Oct 5, 2018
@knz knz mentioned this issue Jan 13, 2020
Merged
@craig craig bot closed this as completed in bc5a9f1 Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-community Originated from the community S-3-ux-surprise Issue leaves users wondering whether CRDB is behaving properly. Likely to hurt reputation/adoption.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server,cli/haproxy: use node liveness to filter the generated conf knz/cockroach
7 participants
@bdarnell @andzdroid @knz @couchand @tbg @dianasaur323 @petermattis