Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Test framework for simulating allocator in different cluster configurations #19131

Closed
a-robinson opened this issue Oct 9, 2017 · 2 comments
Labels
A-kv-distribution Relating to rebalancing and leasing. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-intermediate Intermediate complexity, needs a contributor with 3-6 months of past contribution experience.

Comments

@a-robinson
Copy link
Contributor

We currently test the allocator's decisions in a few manually specified configurations in unit tests, and very few of these do anything interesting with large clusters or multi-locality clusters. More complicated testing has to be done manually with allocsim, which means it doesn't get done often enough of on diverse enough configurations, leading to the possibility of user bug reports like #19013.

We would likely benefit from a simulator like we have for gossip that ensures convergence, i.e. no thrashing. To be of the most benefit, the simulator could randomly generate a configuration of x nodes, spread throughout y localities, with randomly assigned numbers (and sizes) of replicas to start out. The cluster would then be expected to converge and stop rebalancing after some time.

Not required for, but would be nice to help validate #17979.

@a-robinson a-robinson added the E-intermediate Intermediate complexity, needs a contributor with 3-6 months of past contribution experience. label Oct 9, 2017
@a-robinson a-robinson added this to the Later milestone Oct 9, 2017
@petermattis petermattis added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-distribution Relating to rebalancing and leasing. labels Jul 21, 2018
@petermattis petermattis removed this from the Later milestone Oct 5, 2018
@tbg
Copy link
Member

tbg commented Oct 11, 2018

@a-robinson could this be closed for #24818? (I'm just going to do it and rely on your reopening)

@tbg tbg closed this as completed Oct 11, 2018
@a-robinson
Copy link
Contributor Author

It's a different idea, but given that this is just an idea for tests that we don't have active plans to write, I'm fine with closing it. It'd be useful, but there are a lot of things we can do that will be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-distribution Relating to rebalancing and leasing. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-intermediate Intermediate complexity, needs a contributor with 3-6 months of past contribution experience.
Projects
None yet
Development

No branches or pull requests

3 participants