You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
bdarnell opened this issue
May 16, 2017
· 2 comments
Assignees
Labels
C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.E-easyEasy issue to tackle, requires little or no CockroachDB experience
storage.Replica currently implements the etcd/raft.Storage interface directly, which exposes methods with externally-imposed names. Some of these methods require locks to be held (e.g. FirstIndex, but they cannot follow our usual convention of a Locked suffix (they also have some very generic-sounding names like Entries). We should define these methods on a new replicaRaftStorage type alias instead of *Replica itself so they are not used with misleading names elsewhere in the storage package. Any methods that need to be accessible within package storage can be defined on *Replica with a name like raftFirstIndexLocked.
The text was updated successfully, but these errors were encountered:
bdarnell
added
C-cleanup
Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
E-easy
Easy issue to tackle, requires little or no CockroachDB experience
labels
May 16, 2017
C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.E-easyEasy issue to tackle, requires little or no CockroachDB experience
storage.Replica
currently implements theetcd/raft.Storage
interface directly, which exposes methods with externally-imposed names. Some of these methods require locks to be held (e.g.FirstIndex
, but they cannot follow our usual convention of aLocked
suffix (they also have some very generic-sounding names likeEntries
). We should define these methods on a newreplicaRaftStorage
type alias instead of*Replica
itself so they are not used with misleading names elsewhere in the storage package. Any methods that need to be accessible within packagestorage
can be defined on*Replica
with a name likeraftFirstIndexLocked
.See #15935 (comment)
The text was updated successfully, but these errors were encountered: