Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: write ARRAY encoding RFC #15818

Closed
cuongdo opened this issue May 9, 2017 · 4 comments
Closed

sql: write ARRAY encoding RFC #15818

cuongdo opened this issue May 9, 2017 · 4 comments
Assignees
Milestone

Comments

@cuongdo
Copy link
Contributor

cuongdo commented May 9, 2017

One of the first steps for adding full support for ARRAY columns (#2115) is the creation of an RFC for the KV encoding of ARRAYs. Possible considerations are:

  1. Future-proofing. It'll be significant effort to change the encoding later
  2. Efficient support for expected access patterns (see this comment on 2115 for some ideas)
  3. Multi-dimensional arrays

cc @jordanlewis @knz for other thoughts regarding what should go into the RFC

@cuongdo cuongdo added this to the 1.1 milestone May 9, 2017
@knz
Copy link
Contributor

knz commented May 9, 2017 via email

@petermattis
Copy link
Collaborator

@knz I believe the focus of the RFC is encoding ARRAYS into values, not keys (which would be necessary to use an ARRAY column in an index).

A big question to answer is if an ARRAY is encoded into a single KV or if it can be split across multiple KVs. The former would place limits on the size of the ARRAY. The latter introduces complexity and questions about how we specify (or heuristically determine) where the breakpoints are performed.

@vivekmenezes
Copy link
Contributor

This is done right?

@justinj
Copy link
Contributor

justinj commented Jun 19, 2017

Yes!

@justinj justinj closed this as completed Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants