Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: send MsgApp traffic on a separate gRPC stream #15808

Closed
petermattis opened this issue May 9, 2017 · 2 comments
Closed

storage: send MsgApp traffic on a separate gRPC stream #15808

petermattis opened this issue May 9, 2017 · 2 comments
Milestone

Comments

@petermattis
Copy link
Collaborator

Forked from #15702:

Also, pulling on the thread a little further, even if they are not reproposed, commands this large are sufficient to cause heartbeats to be delayed, perhaps to the point of causing elections. Maybe MsgApp messages should use separate GRPC streams (similar to the way that MsgSnap used to). This would need a lot of testing (we want to minimize the chance that MsgApps are reordered with respect to each other, but I think raft will tolerate reorderings of different message types reasonably well)

To be clear, MsgSnap still uses a different stream, but that is due to it using a different endpoint.

@petermattis petermattis added this to the 1.1 milestone May 9, 2017
@cuongdo cuongdo modified the milestones: 1.2, 1.1 Aug 22, 2017
@cuongdo
Copy link
Contributor

cuongdo commented Aug 22, 2017

@petermattis changing this to 1.2, because it's late to be making this change

@bdarnell bdarnell modified the milestones: 2.0, 2.1 Feb 8, 2018
@nvanbenschoten nvanbenschoten modified the milestones: 2.1, 2.2 Jul 21, 2018
@tbg
Copy link
Member

tbg commented Jul 22, 2018

@bdarnell please reopen if you think it's valuable to keep this open.

@tbg tbg closed this as completed Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants