Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccl/crosscluster/logical: TestMultipleSourcesIntoSingleDest failed #135490

Closed
cockroach-teamcity opened this issue Nov 16, 2024 · 2 comments · Fixed by #135994
Closed

ccl/crosscluster/logical: TestMultipleSourcesIntoSingleDest failed #135490

cockroach-teamcity opened this issue Nov 16, 2024 · 2 comments · Fixed by #135994
Assignees
@msbutler
Labels
A-disaster-recovery branch-master Failures and bugs on the master branch. branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Nov 16, 2024 •
edited by cockroach-jira-scripts
Loading

ccl/crosscluster/logical.TestMultipleSourcesIntoSingleDest failed on master @ e83bc46aa42f2476b4b11b9703b8038c660dc980:

=== RUN   TestMultipleSourcesIntoSingleDest
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestMultipleSourcesIntoSingleDest3604595356
    test_log_scope.go:76: use -show-logs to present logs inline
    logical_replication_job_test.go:1438: waiting for logical replication job 1021337637439668225 to reach replicated time of 1731757912.711583888,0
    jobs_verification.go:218: error scanning '&{<nil> 0xc007bda870}': sql: no rows in result set
    panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestMultipleSourcesIntoSingleDest3604595356
--- FAIL: TestMultipleSourcesIntoSingleDest (14.11s)

Parameters:

  • attempt=1
  • race=true
  • run=1
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/disaster-recovery

This test on roachdash | Improve this report!

Jira issue: CRDB-44591
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery labels Nov 16, 2024
This was referenced Nov 16, 2024
Closed
Closed
@msbutler msbutler self-assigned this Nov 18, 2024
@exalate-issue-sync exalate-issue-sync bot added the P-2 Issues/test failures with a fix SLA of 3 months label Nov 18, 2024
@cockroach-teamcity
Copy link
Member Author

ccl/crosscluster/logical.TestMultipleSourcesIntoSingleDest failed with artifacts on master @ 8eeb7f2ae3b2cede564b46ca47e2353fd147c061:

=== RUN   TestMultipleSourcesIntoSingleDest
    test_log_scope.go:165: test logs captured to: /artifacts/tmp/_tmp/a9cfd62e09137c7c70d57ded819e9790/logTestMultipleSourcesIntoSingleDest3273465120
    test_log_scope.go:76: use -show-logs to present logs inline
    logical_replication_job_test.go:1438: waiting for logical replication job 1022397611689639937 to reach replicated time of 1732081390.074141278,0
    jobs_verification.go:218: error scanning '&{<nil> 0x400c5ba360}': sql: no rows in result set
    panic.go:626: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/a9cfd62e09137c7c70d57ded819e9790/logTestMultipleSourcesIntoSingleDest3273465120
--- FAIL: TestMultipleSourcesIntoSingleDest (1.12s)
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

msbutler added a commit to msbutler/cockroach that referenced this issue Nov 22, 2024
@msbutler
crosscluster/logical: only return jobID if planner txn succeeded
e116a92 
PR cockroachdb#134997 introduced a bug where CREATE LOGICAL REPLICATION could return early
with a bogus job id if the txn which writes the job record retried. This patch
prevents this.

Fixes cockroachdb#135176
Fixes cockroachdb#135490

Release note: none
msbutler added a commit to msbutler/cockroach that referenced this issue Nov 22, 2024
@msbutler
crosscluster/logical: only return jobID if planner txn succeeded
bd19c3c 
PR cockroachdb#134997 introduced a bug where CREATE LOGICAL REPLICATION could return early
with a bogus job id if the txn which writes the job record retried. This patch
prevents this.

Note: I plan to open a follow up PR that moves the ldr planning txn into its
own helper func.

Fixes cockroachdb#135176
Fixes cockroachdb#135490

Release note: none
@msbutler msbutler mentioned this issue Nov 22, 2024
Merged
craig bot pushed a commit that referenced this issue Nov 22, 2024
@msbutler
Merge #135994
cc71884 
135994: crosscluster/logical: only return jobID if planner txn succeeded r=kev-cao a=msbutler

PR #134997 introduced a bug where CREATE LOGICAL REPLICATION could return early with a bogus job id if the txn which writes the job record retried. This patch prevents this.

Note: I plan to open a follow up PR that moves the ldr planning txn into its own helper func.

Fixes #135176
Fixes #135490

Release note: none

Co-authored-by: Michael Butler <[email protected]>
@craig craig bot closed this as completed in 38db713 Nov 22, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Nov 22, 2024

Based on the specified backports for linked PR #135994, I applied the following new label(s) to this issue: branch-release-24.3. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 label Nov 22, 2024
blathers-crl bot pushed a commit that referenced this issue Nov 22, 2024
@msbutler
crosscluster/logical: only return jobID if planner txn succeeded
bb53132 
PR #134997 introduced a bug where CREATE LOGICAL REPLICATION could return early
with a bogus job id if the txn which writes the job record retried. This patch
prevents this.

Note: I plan to open a follow up PR that moves the ldr planning txn into its
own helper func.

Fixes #135176
Fixes #135490

Release note: none
@blathers-crl blathers-crl bot mentioned this issue Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msbutler msbutler

Labels
A-disaster-recovery branch-master Failures and bugs on the master branch. branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crosscluster/logical: only return jobID if planner txn succeeded msbutler/cockroach
2 participants
@cockroach-teamcity @msbutler