Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colexecerror: some runtime panics are no longer recovered from #133617

Closed
yuzefovich opened this issue Oct 28, 2024 · 0 comments · Fixed by #133620
Closed

colexecerror: some runtime panics are no longer recovered from #133617

yuzefovich opened this issue Oct 28, 2024 · 0 comments · Fixed by #133620
Assignees
@yuzefovich
Labels
branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Oct 28, 2024 •
edited by cockroach-jira-scripts
Loading

It appears that as of a recent improvement to the stack examination when recovering from panics in #123277 we no longer convert some runtime panics into internal errors (e.g. the reproduction from #130402 (comment) crashes the server). This is because we see runtime.panicdottypeE as the "panic emitted from" line, and my guess is that debug.Stack() - that we used before the patch - omits all runtime related lines from the stack.

Jira issue: CRDB-43709
@yuzefovich yuzefovich added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team labels Oct 28, 2024
@yuzefovich yuzefovich self-assigned this Oct 28, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Oct 28, 2024
@yuzefovich yuzefovich moved this from Triage to Active in SQL Queries Oct 28, 2024
@yuzefovich yuzefovich added branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 labels Oct 28, 2024
@cockroachdb cockroachdb deleted a comment from blathers-crl bot Oct 28, 2024
@yuzefovich yuzefovich mentioned this issue Oct 28, 2024
Merged
@craig craig bot closed this as completed in 615110b Oct 29, 2024
@github-project-automation github-project-automation bot moved this from Active to Done in SQL Queries Oct 29, 2024
This was referenced Oct 29, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 branch-release-24.1 Used to mark GA and release blockers, technical advisories, and bugs for 24.1 branch-release-24.2 Used to mark GA and release blockers, technical advisories, and bugs for 24.2 branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

colexecerror: improve the catcher due to a recent regression yuzefovich/cockroach
1 participant
@yuzefovich