sql/tests: TestRandomSyntaxGeneration failed [CREATE TENANT statement is not valid after parsing then formatting]

[cockroach-teamcity]

sql/tests.TestRandomSyntaxGeneration failed with artifacts on release-24.1.6-rc @ 5ca308c616cee5939f4be345069d4f3849617fd3:

    rsg_test.go:117: Last executed (4): COPY FAMILY ( STRING ) TO STDOUT
    rsg_test.go:117: Last executed (5): PREPARE ident AS EXPERIMENTAL SCRUB DATABASE LANGUAGE
    rsg_test.go:117: Last executed (6): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (7): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (8): COPY ident . BIGINT . ident ( UNLOGGED ) TO STDOUT FORCE NULL error
    rsg_test.go:117: Last executed (9): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (10): MOVE ABSOLUTE - 135 ident
    rsg_test.go:117: Last executed (11): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (12): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (13): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (14): PREPARE ident ( POLYGON error ARRAY [ 42 ] [ error , ident . POSITION . PROCEDURE [ ] , POINT error ARRAY , @ -250 ARRAY [ 348 ] , POINT error [ ] [ error ) AS OPT PLAN 'string'
    rsg_test.go:117: Last executed (15): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (16): UNLISTEN IFNULL . LOCALTIME
    rsg_test.go:117: Last executed (17): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (18): COPY ident . LATERAL ( ident ) FROM error
    rsg_test.go:117: Last executed (19): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (20): UNLISTEN NOTHING_AFTER_RETURNING . SUBSTRING . POINTM
    rsg_test.go:117: Last executed (21): PREPARE ident ( ident . ADD , POLYGON error ARRAY [ -336 ] , GEOGRAPHY ARRAY [ 8 ] [ error , @ 240 ) AS PAUSE ALL error
    rsg_test.go:117: Last executed (22): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (23): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (24): UNLISTEN DEBUG_PAUSE_ON . NO_ZIGZAG_JOIN
    rsg_test.go:117: Last executed (25): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (26): FETCH LAST LOW
    rsg_test.go:117: Last executed (27): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (28): COMMENT ON DATABASE WRITE IS NULL
    rsg_test.go:117: Last executed (29): COMMENT ON CONSTRAINT TIMESTAMP ON INDEX_BEFORE_PAREN . IS IS 'string'
    rsg_test.go:117: Last executed (30): MOVE PRIOR PAUSE
    rsg_test.go:117: Last executed (31): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (32): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (33): REFRESH MATERIALIZED VIEW CONCURRENTLY FAMILY . RANGE
    rsg_test.go:117: Last executed (34): PREPARE SETOF AS EXPLAIN error
    rsg_test.go:117: Last executed (35): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (36): REASSIGN OWNED BY CURRENT_USER , ident , ident TO EXPERIMENTAL
    rsg_test.go:117: Last executed (37): SET SESSION TRANSACTION PRIORITY HIGH DEFERRABLE , NOT DEFERRABLE
    rsg_test.go:117: Last executed (38): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (39): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (40): MOVE ABSOLUTE - 260 ident
    rsg_test.go:117: Last executed (41): COMMENT ON COLUMN INDEX_BEFORE_PAREN . SETOF . JOIN . NOTNULL IS NULL
    rsg_test.go:117: Last executed (42): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (43): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (44): COPY ident . TRIM . INNER FROM error
    rsg_test.go:117: Last executed (45): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (46): CREATE DATABASE IF NOT EXISTS ident
    rsg_test.go:117: Last executed (47): MOVE IN OWNER
    rsg_test.go:117: Last executed (48): PREPARE COST ( POLYGON error ARRAY [ -441 ] , @ -411 ARRAY [ -251 ] ) AS OPT PLAN 'string'
    rsg_test.go:117: Last executed (49): PREPARE VARBIT AS CREATE error
    rsg_test.go:120: Currently active statements: map[]
    rsg_test.go:356: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/d437d2c847dfedbc4972f231c3331c8e/logTestRandomSyntaxGeneration2725703007
--- FAIL: TestRandomSyntaxGeneration (301.85s)

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-43144

[rafiss]

    rsg_test.go:982: cannot parse output of Format: sql="CREATE TENANT OPERATOR ( ) LIKE b'bytes'", formattedSQL="CREATE VIRTUAL CLUSTER (operator()) LIKE b'bytes'": at or near ")": syntax error

This seems like a minor edge case in how we format/normalize the CREATE TENANT statement. I'll move to the DB Server team, but since some parts of the syntax rules are pretty old, feel free to reach out to me so we can work together on finding a solution.