Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crosscluster/ldr: add a few more interesting kinds of tables to the deny list until we set up explicit tests for them #132304

Closed
msbutler opened this issue Oct 10, 2024 · 2 comments · Fixed by #133079
Closed

crosscluster/ldr: add a few more interesting kinds of tables to the deny list until we set up explicit tests for them #132304

msbutler opened this issue Oct 10, 2024 · 2 comments · Fixed by #133079
Assignees
@rafiss
Labels
A-disaster-recovery branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@msbutler
Copy link
Collaborator

msbutler commented Oct 10, 2024 •
edited
Loading

Tables which reference:

  • a UDF
  • a sequence
  • a trigger
  • stored procs

Jira issue: CRDB-42938
Epic CRDB-41465
@msbutler msbutler added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery GA-blocker 24.3 labels Oct 10, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Oct 10, 2024

cc @cockroachdb/disaster-recovery

@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Oct 10, 2024

Hi @msbutler, please add branch-* labels to identify which branch(es) this GA-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-disaster-recovery labels Oct 10, 2024
@rafiss rafiss added the branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 label Oct 10, 2024
@celiala celiala removed the 24.3 label Oct 14, 2024
@rafiss rafiss mentioned this issue Oct 21, 2024
Merged
@craig craig bot closed this as completed in 4a5e4d2 Oct 21, 2024
@blathers-crl blathers-crl bot mentioned this issue Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
A-disaster-recovery branch-release-24.3 Used to mark GA and release blockers, technical advisories, and bugs for 24.3 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tabledesc: disallow LDR for tables that reference UDFs/sequences rafiss/cockroach
3 participants
@rafiss @celiala @msbutler