Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rac2: implement handle raft ready #129668

Closed
Tracked by #123509
kvoli opened this issue Aug 26, 2024 · 0 comments · Fixed by #129759
Closed
Tracked by #123509

rac2: implement handle raft ready #129668

kvoli opened this issue Aug 26, 2024 · 0 comments · Fixed by #129759
Assignees
@kvoli
Labels
A-replication-admission-control-v2 Related to introduction of replication AC v2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@kvoli
Copy link
Collaborator

kvoli commented Aug 26, 2024 •
edited by exalate-issue-sync bot
Loading

Currently, RAC v2 does not support most functionality due to missing HandleRaftReady on the leaders RangeController. This issue is to implement said functionality necessary to support WaitForEval.

Jira issue: CRDB-41655

Epic CRDB-37515
@kvoli kvoli added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-replication-admission-control-v2 Related to introduction of replication AC v2 labels Aug 26, 2024
@blathers-crl blathers-crl bot added the T-kv KV Team label Aug 26, 2024
@kvoli kvoli self-assigned this Aug 26, 2024
@exalate-issue-sync exalate-issue-sync bot added T-kv KV Team and removed T-kv KV Team labels Aug 26, 2024
@kvoli kvoli mentioned this issue Aug 26, 2024
Closed
@kvoli kvoli mentioned this issue Aug 27, 2024
Merged
@github-project-automation github-project-automation bot moved this to Incoming in KV Aug 28, 2024
kvoli added a commit to kvoli/cockroach that referenced this issue Aug 28, 2024
@kvoli
rac2: [dnm] implement handle raft event
3c2d089 
This commit implements `HandleRaftEvent` on the `RangeController`. When
`HandleRaftEvent` is called by the `Processor` on the leader, the
`RangeController` will perform local replica state management for the
range and potentially return tokens if admitted has advanced.
Additionally, any entries will subject to admission control will have
corresponding tokens deducted and tracked.

Resolves: cockroachdb#129668
Release note: None
kvoli added a commit to kvoli/cockroach that referenced this issue Aug 28, 2024
@kvoli
rac2: [dnm] implement handle raft event
f7760bb 
This commit implements `HandleRaftEvent` on the `RangeController`. When
`HandleRaftEvent` is called by the `Processor` on the leader, the
`RangeController` will perform local replica state management for the
range and potentially return tokens if admitted has advanced.
Additionally, any entries will subject to admission control will have
corresponding tokens deducted and tracked.

Resolves: cockroachdb#129668
Release note: None
kvoli added a commit to kvoli/cockroach that referenced this issue Aug 29, 2024
@kvoli
rac2: implement handle raft event
e183cf7 
This commit implements `HandleRaftEvent` on the `RangeController`. When
`HandleRaftEvent` is called by the `Processor` on the leader, the
`RangeController` will perform local replica state management for the
range and potentially return tokens if admitted has advanced.
Additionally, any entries will subject to admission control will have
corresponding tokens deducted and tracked.

Resolves: cockroachdb#129668
Release note: None
kvoli added a commit to kvoli/cockroach that referenced this issue Aug 29, 2024
@kvoli
rac2: implement handle raft event
e56a5d0 
This commit implements `HandleRaftEvent` on the `RangeController`. When
`HandleRaftEvent` is called by the `Processor` on the leader, the
`RangeController` will perform local replica state management for the
range and potentially return tokens if admitted has advanced.
Additionally, any entries will subject to admission control will have
corresponding tokens deducted and tracked.

Resolves: cockroachdb#129668
Release note: None
craig bot pushed a commit that referenced this issue Aug 29, 2024
@kvoli
Merge #129759
91faa66 
129759: rac2: implement handle raft event r=sumeerbhola a=kvoli

This commit implements `HandleRaftEvent` on the `RangeController`. When `HandleRaftEvent` is called by the `Processor` on the leader, the `RangeController` will perform local replica state management for the range and potentially return tokens if admitted has advanced. Additionally, any entries will subject to admission control will have corresponding tokens deducted and tracked.

Resolves: #129668
Release note: None

Co-authored-by: Austen McClernon <[email protected]>
@kvoli kvoli mentioned this issue Aug 29, 2024
Open
26 tasks
@craig craig bot closed this as completed in 891e8ce Aug 29, 2024
@github-project-automation github-project-automation bot moved this from Incoming to Closed in KV Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvoli kvoli

Labels
A-replication-admission-control-v2 Related to introduction of replication AC v2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
No open projects
KV
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rac2: implement handle raft event kvoli/cockroach
1 participant
@kvoli