Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: support range replica set changes in rac2 #128915

Closed
Tracked by #123509
kvoli opened this issue Aug 13, 2024 · 1 comment · Fixed by #129263
Closed
Tracked by #123509

kv: support range replica set changes in rac2 #128915

kvoli opened this issue Aug 13, 2024 · 1 comment · Fixed by #129263
Assignees
@kvoli
Labels
A-replication-admission-control-v2 Related to introduction of replication AC v2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@kvoli
Copy link
Collaborator

kvoli commented Aug 13, 2024 •
edited by exalate-issue-sync bot
Loading

This issue is to add support for a changing range replica set (expected upon rebalancing, promotion, demotion etc) in replication admission control v2. After this issue is complete, rac2 should implement:

https://github.com/sumeerbhola/cockroach/blob/5c2a50ec4d0dcf2502d742ac9036d39995886abc/pkg/kv/kvserver/kvflowcontrol/kvflowconnectedstream/stream.go#L1294-L1299

And integrate calls to the RangeController method above:

https://github.com/sumeerbhola/cockroach/blob/5c2a50ec4d0dcf2502d742ac9036d39995886abc/pkg/kv/kvserver/flow_control_replica_integration.go#L678-L680

Jira issue: CRDB-41278

Epic CRDB-37515
@kvoli kvoli added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-replication-admission-control-v2 Related to introduction of replication AC v2 labels Aug 13, 2024
@blathers-crl blathers-crl bot added the T-kv KV Team label Aug 13, 2024
@kvoli kvoli mentioned this issue Aug 13, 2024
Open
26 tasks
@kvoli kvoli mentioned this issue Aug 26, 2024
Closed
@github-project-automation github-project-automation bot moved this to Incoming in KV Aug 28, 2024
@kvoli
Copy link
Collaborator Author

kvoli commented Aug 29, 2024

Marking as complete via #129263 and #128927. Which implements the integration and controller changes required to support descriptor changes.

@kvoli kvoli closed this as completed Aug 29, 2024
@github-project-automation github-project-automation bot moved this from Incoming to Closed in KV Aug 29, 2024
@kvoli kvoli linked a pull request Aug 29, 2024 that will close this issue
rac2: implement wait for eval #129263
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvoli kvoli

Labels
A-replication-admission-control-v2 Related to introduction of replication AC v2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
No open projects
KV
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rac2: implement wait for eval kvoli/cockroach
1 participant
@kvoli