Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/catalog/lease: TestLeaseAtLatestVersion failed #128701

Closed
cockroach-teamcity opened this issue Aug 9, 2024 · 1 comment · Fixed by #128931
Closed

sql/catalog/lease: TestLeaseAtLatestVersion failed #128701

cockroach-teamcity opened this issue Aug 9, 2024 · 1 comment · Fixed by #128931
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 9, 2024

sql/catalog/lease.TestLeaseAtLatestVersion failed with artifacts on master @ 22c9923eb9854b9e31068234599edce7c856fbde:

Fatal error:

panic: test timed out after 14m57s
running tests:
	TestLeaseAtLatestVersion (14m35s)

Stack:

goroutine 74736 [running]:
testing.(*M).startAlarm.func1()
	GOROOT/src/testing/testing.go:2366 +0x30c
created by time.goFunc
	GOROOT/src/time/sleep.go:177 +0x38
Log preceding fatal error

=== RUN   TestLeaseAtLatestVersion
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/5632b52c1c67b61307e1d8a1ca2dd18d/logTestLeaseAtLatestVersion373407812
    test_log_scope.go:81: use -show-logs to present logs inline
    test_server_shim.go:157: automatically injected an external process virtual cluster under test; see comment at top of test_server_shim.go for details.

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-41153

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Aug 9, 2024
@rafiss
Copy link
Collaborator

rafiss commented Aug 13, 2024

It looks like this is stuck waiting for the singleflight to acquire a lease.

[14:13:58 ](https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Ci_TestsAwsLinuxArm64_UnitTests/16398043?buildTab=log&focusLine=10719&logView=flowAware&linesState=10719)    goroutine 36464 [select, 14 minutes]:
[14:13:58 ](https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Ci_TestsAwsLinuxArm64_UnitTests/16398043?buildTab=log&focusLine=10720&logView=flowAware&linesState=10720)    github.com/cockroachdb/cockroach/pkg/util/syncutil/singleflight.(*call).result(0x4008d2fb80, {0x63f30b0, 0x40080f6840}, 0x1)
14:13:58       github.com/cockroachdb/cockroach/pkg/util/syncutil/singleflight/singleflight.go:250 +0xa4
14:13:58     github.com/cockroachdb/cockroach/pkg/util/syncutil/singleflight.Future.WaitForResult(...)
[14:13:58 ](https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Ci_TestsAwsLinuxArm64_UnitTests/16398043?buildTab=log&focusLine=10721&logView=flowAware&linesState=10721)      github.com/cockroachdb/cockroach/pkg/util/syncutil/singleflight/singleflight.go:234
14:13:58     github.com/cockroachdb/cockroach/pkg/sql/catalog/lease.acquireNodeLease({0x63f30b0, 0x40080f6840}, 0x40086c4908, 0x6a, 0x0)
[14:13:58 ](https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Ci_TestsAwsLinuxArm64_UnitTests/16398043?buildTab=log&focusLine=10722&logView=flowAware&linesState=10722)      github.com/cockroachdb/cockroach/pkg/sql/catalog/lease/lease.go:701 +0x190
14:13:58     github.com/cockroachdb/cockroach/pkg/sql/catalog/lease.(*Manager).Acquire.func1(0x4013770120, {0x63f30b0, 0x40080f6840}, 0x40086c4908, 0x6a)
[14:13:58 ](https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Ci_TestsAwsLinuxArm64_UnitTests/16398043?buildTab=log&focusLine=10723&logView=flowAware&linesState=10723)      github.com/cockroachdb/cockroach/pkg/sql/catalog/lease/lease.go:1279 +0x88
14:13:58     github.com/cockroachdb/cockroach/pkg/sql/catalog/lease.(*Manager).Acquire(0x40086c4908, {0x63f30b0, 0x40080f6840}, {0x6900000068?, 0xaa00119?}, 0x6a)
[14:13:58 ](https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Ci_TestsAwsLinuxArm64_UnitTests/16398043?buildTab=log&focusLine=10724&logView=flowAware&linesState=10724)      github.com/cockroachdb/cockroach/pkg/sql/catalog/lease/lease.go:1281 +0xb4

We might be able to fix by adjusting this testing knob so it blocks if desc.GetVersion() < 2 rather than desc.GetVersion() != 2:

if desc.GetVersion() != 2 {

I'll try to repro and make the change.

@exalate-issue-sync exalate-issue-sync bot added P-2 Issues/test failures with a fix SLA of 3 months and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Aug 13, 2024
@craig craig bot closed this as completed in 739cc7d Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants