kv: add microbenchmarks for replication ac v2 #128034
Assignees
Labels
A-replication-admission-control-v2
Related to introduction of replication AC v2
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-kv
KV Team
Comments
kvoli
added
C-enhancement
26 tasks
sumeerbhola
added a commit
to sumeerbhola/cockroach
that referenced
this issue
Sep 30, 2024
Make small logging tweaks in rac2 to avoid allocations caused by passing a
value through an interface{}.
On my m1 macbook:
BenchmarkFlowControlV2Basic/v2_enabled_when_leader_level=1 4840 262413 ns/op 96600 B/op 267 allocs/op
BenchmarkFlowControlV2Basic/v2_enabled_when_leader_level=2 5752 266266 ns/op 96621 B/op 267 allocs/op
RAC2 code isn't visible in the cpu profile and is < 1% of the memory
profile.
Informs cockroachdb#128034
Epic: CRDB-37515
Release note: None
|
Existing v1 benchmark: |
craig bot
pushed a commit
that referenced
this issue
Oct 1, 2024
131631: kvserver,rac2: add BenchmarkFlowControlV2Basic r=kvoli a=sumeerbhola
Make small logging tweaks in rac2 to avoid allocations caused by passing a value through an interface{}.
On my m1 macbook:
```
BenchmarkFlowControlV2Basic/v2_enabled_when_leader_level=1 4840 262413 ns/op 96600 B/op 267 allocs/op
BenchmarkFlowControlV2Basic/v2_enabled_when_leader_level=2 5752 266266 ns/op 96621 B/op 267 allocs/op
```
RAC2 code isn't visible in the cpu profile and is < 1% of the memory profile.
Informs #128034
Epic: CRDB-37515
Release note: None
131680: logictest: deflake TestLogic_union r=rafiss a=rafiss
Breaking up the large transaction should help avoid context cancellation errors.
fixes #131324
Release note: None
Co-authored-by: sumeerbhola <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Similar to existing micro-benchmarks for v1, introduce a suite of microbenchmarks for replication ac v2.
The microbenchmarks should at a minimum test at the (1) integration and the (2) controller level.
Jira issue: CRDB-40746
Epic CRDB-37515
The text was updated successfully, but these errors were encountered: