Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvflowcontrol: implement store streams token counter #128027

Closed
Tracked by #123509
kvoli opened this issue Jul 31, 2024 · 0 comments · Fixed by #128221
Closed
Tracked by #123509

kvflowcontrol: implement store streams token counter #128027

kvoli opened this issue Jul 31, 2024 · 0 comments · Fixed by #128221
Assignees
@kvoli
Labels
A-replication-admission-control-v2 Related to introduction of replication AC v2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@kvoli
Copy link
Collaborator

kvoli commented Jul 31, 2024 •
edited by exalate-issue-sync bot
Loading

Implement the methods defined by #128010. See prototype code for a rough guide.

Jira issue: CRDB-40759

Epic CRDB-37515
@kvoli kvoli added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-replication-admission-control-v2 Related to introduction of replication AC v2 labels Jul 31, 2024
@blathers-crl blathers-crl bot added the T-kv KV Team label Jul 31, 2024
@kvoli kvoli mentioned this issue Aug 2, 2024
Merged
@kvoli kvoli self-assigned this Aug 2, 2024
kvoli added a commit to kvoli/cockroach that referenced this issue Aug 6, 2024
@kvoli
rac2: implement stream token counter provider
cd86584 
Replace the existing `StreamTokenCounterProvider` interface with a
struct implementation. `StreamTokenCounterProvider` provides two
methods, `Send` and `Eval`, which should be used to access a (eval|send)
token counter for a given stream on a node.

Resolves: cockroachdb#128027
Release note: None
kvoli added a commit to kvoli/cockroach that referenced this issue Aug 7, 2024
@kvoli
rac2: implement stream token counter provider
c112ea6 
Replace the existing `StreamTokenCounterProvider` interface with a
struct implementation. `StreamTokenCounterProvider` provides two
methods, `Send` and `Eval`, which should be used to access a (eval|send)
token counter for a given stream on a node.

Resolves: cockroachdb#128027
Release note: None
kvoli added a commit to kvoli/cockroach that referenced this issue Aug 8, 2024
@kvoli
rac2: implement stream token counter provider
dbf8b56 
Replace the existing `StreamTokenCounterProvider` interface with a
struct implementation. `StreamTokenCounterProvider` provides two
methods, `Send` and `Eval`, which should be used to access a (eval|send)
token counter for a given stream on a node.

Resolves: cockroachdb#128027
Release note: None
craig bot pushed a commit that referenced this issue Aug 12, 2024
@Uzair5162 @kvoli @jaylim-crl
Merge #127836 #128221 #128602
29b806e 
127836: sql: support partial stats at extremes without specifying columns r=Uzair5162 a=Uzair5162

This commit adds support to collect partial statistics at extremes without specifying a column, such as:

`CREATE STATISTICS my_stat FROM t USING EXTREMES`

This will collect partial stats on a default set of columns, which are all single columns that are prefixes of forward indexes, excluding partial, sharded, and implicitly partitioned indexes.

Modifies create stats job progress reporting to work when multiple indexes will be scanned as part of the stat collection. The i'th index scan will only report progress between `(i-1)/numIndexes`% and `i/numIndexes`%. For example, if we expect to scan 4 indexes, each index will report progress between 0%-25%, 25%-50%, 50%-75%, and 75%-100% respectively. Also changes the `rowsExpected` count used by the SampleAggregator and sample size computation to be the estimated number of stale rows computed as `estimated row count * fraction of stale rows` for partial stat collections.

Closes: #127832

Release note (sql): Partial stats at extremes can now be collected on all valid columns of a table using the `CREATE STATISTICS <stat_name> FROM <table_name> USING EXTREMES` syntax, without an `ON <col_name>` clause. Valid columns are all single column prefixes of a forward index excluding partial, sharded, and implicitly partitioned indexes.

128221: rac2: implement stream token counter provider  r=pav-kv,sumeerbhola a=kvoli

First two commits from #128217

---

Replace the existing `StreamTokenCounterProvider` interface with a
struct implementation. `StreamTokenCounterProvider` provides two
methods, `Send` and `Eval`, which should be used to access a (eval|send)
token counter for a given stream on a node.

Resolves: #128027
Release note: None

128602: pkg/server: add tenant_id to Sentry context for tenants r=andy-kimball,xinhaoz a=jaylim-crl

Previously, Sentry context for tenants included the logical cluster ID and
instance ID, but those information are insufficient to locate the tenant right
away. This commit ensures that Sentry context for tenants includes the
tenant_id field as part of Sentry reports. Note that one could already figure
out the tenant_id from the existing information, but they would need to compute
the tenant_id manually using a combination of the host's cluster ID and the
tenant's cluster ID, which can be cumbersome.

Release note: None

Epic: none

Co-authored-by: Uzair Ahmad <[email protected]>
Co-authored-by: Austen McClernon <[email protected]>
Co-authored-by: Jay <[email protected]>
@craig craig bot closed this as completed in c936ff0 Aug 12, 2024
@kvoli kvoli mentioned this issue Aug 13, 2024
Open
26 tasks
@github-project-automation github-project-automation bot moved this to Incoming in KV Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvoli kvoli

Labels
A-replication-admission-control-v2 Related to introduction of replication AC v2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
No open projects
KV
Status: Incoming
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rac2: implement stream token counter provider kvoli/cockroach
1 participant
@kvoli