Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: zone config changes should apply immediately #127180

Open
andrewbaptist opened this issue Jul 15, 2024 · 0 comments
Open

kv: zone config changes should apply immediately #127180

andrewbaptist opened this issue Jul 15, 2024 · 0 comments
Labels
A-kv-distribution Relating to rebalancing and leasing. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@andrewbaptist
Copy link
Collaborator

andrewbaptist commented Jul 15, 2024

Is your feature request related to a problem? Please describe.
After a user changes a ZONE CONFIG using an alter statement, they expect the system to "quickly" process the change. After the work done to address #108795 we eagerly queue up the SpanConfig changes, however due to rate limits and other failures, we don't process 100% of them successfully the first time and we don't retry quickly.

This was exposed from a change to change-replicas/mixed-version to incorrectly no longer pass the COCKROACH_SCAN_MAX_IDLE_TIME=10ms parameter in #127106.

Describe the solution you'd like
Ideally we should be able to remove that parameter and config setting from all the tests (unless they really are testing the scan interval). This mostly works, but we don't have a good roachtest to validate it and as this failure exposed, it doesn't work 100% of the time.

Jira issue: CRDB-40307

Epic CRDB-39952

@andrewbaptist andrewbaptist added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-kv-distribution Relating to rebalancing and leasing. T-kv KV Team labels Jul 15, 2024
@github-project-automation github-project-automation bot moved this to Incoming in KV Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-distribution Relating to rebalancing and leasing. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
No open projects
Status: Incoming
Development

No branches or pull requests

1 participant