Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: background job inheriting from cluster setting #126806

Open
annrpom opened this issue Jul 8, 2024 · 0 comments
Open

server: background job inheriting from cluster setting #126806

annrpom opened this issue Jul 8, 2024 · 0 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@annrpom
Copy link
Contributor

annrpom commented Jul 8, 2024 •
edited by cockroach-jira-scripts
Loading

In #101486, we started inheriting from cluster settings. This change makes it so that instead of the go default for session variables, background jobs inherit from the global default (cluster setting's) value. This does not make particular sense in cases like statement timeouts. There may be other instances where we do not prefer global defaults to be applied to background jobs; this issue will track the existence of the pattern.

For a fix/more context, see: #126336, https://github.com/cockroachlabs/support/issues/2998

Jira issue: CRDB-40144
@annrpom annrpom added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annrpom