Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/ccl/testccl/sqlstatsccl/sqlstatsccl_test: TestSQLStatsRegions failed #126049

Closed
cockroach-teamcity opened this issue Jun 21, 2024 · 1 comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-observability

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jun 21, 2024

pkg/ccl/testccl/sqlstatsccl/sqlstatsccl_test.TestSQLStatsRegions failed with artifacts on master @ 4a708c864424fd0163738869ab2602a958ad2c09:

=== RUN   TestSQLStatsRegions
    test_log_scope.go:170: test logs captured to: /artifacts/tmp/_tmp/1ffa8747a1250ee574ba4234d629ddbd/logTestSQLStatsRegions1961328159
    test_log_scope.go:81: use -show-logs to present logs inline
--- FAIL: TestSQLStatsRegions (61.47s)
=== RUN   TestSQLStatsRegions/system_tenant
    --- FAIL: TestSQLStatsRegions/system_tenant (48.03s)
panic: Counters should not decrease [recovered]
	panic: Counters should not decrease

goroutine 22106 [running]:
testing.tRunner.func1.2({0x52d6840, 0x7785250})
	GOROOT/src/testing/testing.go:1631 +0x1c4
testing.tRunner.func1()
	GOROOT/src/testing/testing.go:1634 +0x33c
panic({0x52d6840?, 0x7785250?})
	GOROOT/src/runtime/panic.go:770 +0x124
github.com/cockroachdb/cockroach/pkg/util/metric.(*Counter).Update(...)
	github.com/cockroachdb/cockroach/pkg/util/metric/pkg/util/metric/metric.go:755
github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*StoreMetrics).updateEngineMetrics(_, {0x401f6a3208, {0x3e33bfd, 0x2ec5c, 0xe886b0, 0x1b6e, 0x52af, 0x1b6c, 0x1638e}, {0x1a29, ...}, ...})
	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/metrics.go:3789 +0xd64
github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Store).computeMetrics(_, {_, _})
	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/store.go:3478 +0xe0
github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Store).ComputeMetrics(...)
	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/store.go:3590
github.com/cockroachdb/cockroach/pkg/testutils/testcluster.(*TestCluster).WaitForFullReplication.func2(0x40088fb508)
	github.com/cockroachdb/cockroach/pkg/testutils/testcluster/testcluster.go:1443 +0xac
github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Stores).VisitStores.func1(0x400bb657f8?, 0x4008cf14d0?)
	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/stores.go:150 +0x34
github.com/cockroachdb/cockroach/pkg/util/syncutil.(*IntMap).Range(0x400bb658a8?, 0x40229a7890)
	github.com/cockroachdb/cockroach/pkg/util/syncutil/int_map.go:385 +0xe0
github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Stores).VisitStores(0x77efcc8?, 0xb7aefc0?)
	github.com/cockroachdb/cockroach/pkg/kv/kvserver/pkg/kv/kvserver/stores.go:149 +0x4c
github.com/cockroachdb/cockroach/pkg/testutils/testcluster.(*TestCluster).WaitForFullReplication(0x40050c0a08)
	github.com/cockroachdb/cockroach/pkg/testutils/testcluster/testcluster.go:1432 +0x2d8
pkg/ccl/testccl/sqlstatsccl/sqlstatsccl_test_test.TestSQLStatsRegions.func2.1()
	pkg/ccl/testccl/sqlstatsccl/sqlstatsccl_test_test/pkg/ccl/testccl/sqlstatsccl/sql_stats_test.go:161 +0x58
github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithinError.func1()
	github.com/cockroachdb/cockroach/pkg/testutils/soon.go:75 +0x40
github.com/cockroachdb/cockroach/pkg/util/retry.ForDuration(0x45d964b800, 0x40229a7d30)
	github.com/cockroachdb/cockroach/pkg/util/retry/retry.go:213 +0xbc
github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithinError(0x4006a6bef0, 0x45d964b800)
	github.com/cockroachdb/cockroach/pkg/testutils/soon.go:81 +0x60
github.com/cockroachdb/cockroach/pkg/testutils.SucceedsWithin({0x77c93c8, 0x4016382340}, 0x4006a6bef0, 0x45d964b800)
	github.com/cockroachdb/cockroach/pkg/testutils/soon.go:60 +0x44
pkg/ccl/testccl/sqlstatsccl/sqlstatsccl_test_test.TestSQLStatsRegions.func2(0x4016382340)
	pkg/ccl/testccl/sqlstatsccl/sqlstatsccl_test_test/pkg/ccl/testccl/sqlstatsccl/sql_stats_test.go:160 +0x120
testing.tRunner(0x4016382340, 0x4016d2b650)
	GOROOT/src/testing/testing.go:1689 +0xec
created by testing.(*T).Run in goroutine 27
	GOROOT/src/testing/testing.go:1742 +0x318
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/obs-prs

This test on roachdash | Improve this report!

Jira issue: CRDB-39736

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-observability labels Jun 21, 2024
@yuzefovich
Copy link
Member

dup of #125736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-observability
Projects
None yet
Development

No branches or pull requests

2 participants