Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: pace range split stats computation #125948

Open
kvoli opened this issue Jun 20, 2024 · 0 comments
Open

kvserver: pace range split stats computation #125948

kvoli opened this issue Jun 20, 2024 · 0 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@kvoli
Copy link
Collaborator

kvoli commented Jun 20, 2024

Is your feature request related to a problem? Please describe.

After #22348, the amount of data scanned for stats computation increased. When there are multiple splits occurring in parallel on the same store, this can consume a large amount of CPU.

Describe the solution you'd like

Pace range split stats computation, such as integrating with the elastic AC CPU limiter.

Describe alternatives you've considered
We should also spread out splits where possible, to reduce the likelihood of multiple splits occurring at once. See #22348.

Additional context

Note that some range splits, such as load based, should not be delayed as timely splits are depended upon for load rebalancing. Similarly, a range will begin backpressuring writes after the range exceeds a certain threshold above the maximum range size -- any solution here will need to make a tradeoff between backpressure and pacing stats computation.

Jira issue: CRDB-39679

Epic CRDB-39952

@kvoli kvoli added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team labels Jun 20, 2024
@github-project-automation github-project-automation bot moved this to Incoming in KV Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
No open projects
Status: Incoming
Development

No branches or pull requests

1 participant