roachtest: schemachange/mixed-versions failed [enum value is not yet public (SQLSTATE XXUUU)]

[cockroach-teamcity]

roachtest.schemachange/mixed-versions failed with artifacts on release-24.1 @ 827b522c24d903ec130ea4aa48dd0af6687eaf6d:

(mixedversion.go:594).Run: mixed-version test failure while running step 15 (run "run schemachange workload and validation in mixed version"): full command output in run_062852.573881555_n4_COCKROACHRANDOMSEED1.log: COMMAND_PROBLEM: exit status 1
test artifacts and logs in: /artifacts/schemachange/mixed-versions/run_1

Parameters:

• ROACHTEST_arch=amd64
• ROACHTEST_cloud=gce
• ROACHTEST_coverageBuild=false
• ROACHTEST_cpu=4
• ROACHTEST_encrypted=false
• ROACHTEST_metamorphicBuild=false
• ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

Same failure on other branches

• roachtest: schemachange/mixed-versions failed [attempting to append refresh spans after the tracked timestamp has moved forward] #124792 roachtest: schemachange/mixed-versions failed [C-test-failure O-roachtest O-robot T-sql-foundations branch-release-23.2.6-rc release-blocker]
• roachtest: schemachange/mixed-versions failed [debug doctor validation: existing descriptors that still need to be dropped] #124722 roachtest: schemachange/mixed-versions failed [C-test-failure O-roachtest O-robot T-sql-foundations branch-release-23.1.22-rc]
• roachtest: schemachange/mixed-versions failed [functions cannot have more than 100 arguments] #124390 roachtest: schemachange/mixed-versions failed [functions cannot have more than 100 arguments] [C-test-failure O-roachtest O-robot P-2 T-sql-foundations branch-master]

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-39098

[annrpom]

"workerId": 0,
 "clientTimestamp": "06:29:17.749859",
 "ops": [
  "BEGIN",
  {
   "sql": "ALTER TYPE schema_w2_132.enum_w0_154 DROP VALUE 'dffs'"
  },
  {
   "sql": "CREATE TABLE IF NOT EXISTS schema_w3_175.table_w0_254 (col254_w0_255 GEOMETRY NOT NULL)"
  },
  {
   "sql": "DROP SCHEMA \"schema_w4_198\" CASCADE"
  },
  {
   "sql": "CREATE FUNCTION udf_w0_257()\n\tRETURNS VOID\n\tLANGUAGE SQL\n\tAS $$ SELECT 'dffs'::schema_w2_132.enum_w0_154 $$",
   "expectedExecErr": "22023"
  }
 ],
 "expectedExecErrors": "22023",
 "expectedCommitErrors": "",
 "message": "***UNEXPECTED ERROR; Received an unexpected execution error.: ERROR: enum value \"dffs\" is not yet public (SQLSTATE XXUUU)",

Looks like the actual error message isn't correctly returned in the ALTER TYPE DROP VALUE code even though we expect it in the workload (?):

cockroach/pkg/sql/types/types.go

Line 2734 in 5b6e564

var EnumValueNotYetPublicError = pgerror.New(pgcode.InvalidParameterValue, "enum value is not yet public")

[annrpom]

ah. mixed-version. 23.2 doesn't have the proper error code associated

[email protected]:26257/movr  OPEN> CREATE FUNCTION udf_w0_257()                
                              -> RETURNS VOID                                
                              -> LANGUAGE SQL                                
                              -> AS $$                                       
                              ->     SELECT 'dffs'::enum_w0_154;             
                              -> $$;                                         
ERROR: enum value "dffs" is not yet public

[rafiss]

nice find! backporting that here: #124880